Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect: Make Signature instances picklable #64925

Closed
1st1 opened this issue Feb 22, 2014 · 7 comments
Closed

inspect: Make Signature instances picklable #64925

1st1 opened this issue Feb 22, 2014 · 7 comments
Assignees
Labels
type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Feb 22, 2014

BPO 20726
Nosy @ncoghlan, @pitrou, @vstinner, @larryhastings, @1st1
Files
  • sig_picklable_01.patch
  • sig_picklable_02.patch
  • sig_picklable_03.patch: More tests
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
    closed_at = <Date 2014-03-27.15:32:28.222>
    created_at = <Date 2014-02-22.03:21:53.516>
    labels = ['type-feature']
    title = 'inspect: Make Signature instances picklable'
    updated_at = <Date 2014-03-29.17:24:36.034>
    user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2014-03-29.17:24:36.034>
    actor = 'python-dev'
    assignee = 'yselivanov'
    closed = True
    closed_date = <Date 2014-03-27.15:32:28.222>
    closer = 'python-dev'
    components = []
    creation = <Date 2014-02-22.03:21:53.516>
    creator = 'yselivanov'
    dependencies = []
    files = ['34179', '34186', '34217']
    hgrepos = []
    issue_num = 20726
    keywords = ['patch']
    message_count = 7.0
    messages = ['211903', '211918', '211930', '214955', '214957', '214958', '215135']
    nosy_count = 6.0
    nosy_names = ['ncoghlan', 'pitrou', 'vstinner', 'larry', 'python-dev', 'yselivanov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue20726'
    versions = ['Python 3.5']

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 22, 2014

    There is no reason for Signature objects to be not picklable.
    Patch is attached (it will require merging bpo-19573 before).

    @1st1 1st1 self-assigned this Feb 22, 2014
    @1st1 1st1 added the type-feature A feature request or enhancement label Feb 22, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Feb 22, 2014

    For extra points, you could test with all protocol versions (from 0 to HIGHEST_PROTOCOL).

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 22, 2014

    For extra points, you could test with all protocol versions (from 0 to HIGHEST_PROTOCOL).

    Good idea, see the second patch.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 27, 2014

    New changeset 0a8e3c910c0a by Yury Selivanov in branch 'default':
    inspect.signature: Make Signature and Parameter picklable. Closes bpo-20726
    http://hg.python.org/cpython/rev/0a8e3c910c0a

    @python-dev python-dev mannequin closed this as completed Mar 27, 2014
    @vstinner
    Copy link
    Member

    vstinner commented Mar 27, 2014

    Why not backporting this change to Python 3.4? Would it break something?

    @pitrou
    Copy link
    Member

    pitrou commented Mar 27, 2014

    Picklability is more of a new feature than a bugfix.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 29, 2014

    New changeset f2bae047f6d0 by Yury Selivanov in branch 'default':
    inspect.docs: Document that Signature and Parameter are now picklable (issue bpo-20726)
    http://hg.python.org/cpython/rev/f2bae047f6d0

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants