reset_mock needs parameters to also reset return_value and side_effect

[voidspace]

BPO	21271
Nosy	@voidspace, @PCManticore, @berkerpeksag, @kushaldas
Files	issue21271.patch: New parameters for reset_mock issue21271v2.patch: Version 2 of the patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/voidspace'
closed_at = <Date 2016-06-02.17:23:44.513>
created_at = <Date 2014-04-16.20:51:44.316>
labels = ['type-feature', 'library']
title = 'reset_mock needs parameters to also reset return_value and side_effect'
updated_at = <Date 2016-06-02.17:29:18.239>
user = 'https://github.com/voidspace'

bugs.python.org fields:

activity = <Date 2016-06-02.17:29:18.239>
actor = 'python-dev'
assignee = 'michael.foord'
closed = True
closed_date = <Date 2016-06-02.17:23:44.513>
closer = 'kushal.das'
components = ['Library (Lib)']
creation = <Date 2014-04-16.20:51:44.316>
creator = 'michael.foord'
dependencies = []
files = ['38987', '38989']
hgrepos = []
issue_num = 21271
keywords = ['patch']
message_count = 7.0
messages = ['216588', '240585', '240888', '240890', '240906', '266895', '266896']
nosy_count = 5.0
nosy_names = ['michael.foord', 'Claudiu.Popa', 'python-dev', 'berker.peksag', 'kushal.das']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21271'
versions = ['Python 3.5']

[voidspace]

unittest.mock.Mock.reset_mock deliberately doesn't reset the return_value and side_effect. It would be nice if it gained parameters so that it *could*.

[kushaldas]

Working on it. Will submit the patch tomorrow.

[kushaldas]

A patch without NEWS and whatsnew update. I will fill them before commit.

The reset_mock function now has two parameters, return_value, and side_effect. Passing True value to any of these will reset that attribute.

[berkerpeksag]

I left a couple of comments of Rietveld.

[kushaldas]

Updated patch with the suggestions from Berker.

[kushaldas]

Fixed in https://hg.python.org/cpython/rev/b110dd3d6cea

[python-dev]

New changeset b110dd3d6cea by Kushal Das in branch 'default':
Issue bpo-21271: Adds new keyword only parameters in reset_mock call
https://hg.python.org/cpython/rev/b110dd3d6cea