PEP 466: backport hashlib changes

[ncoghlan]

BPO	21307
Nosy	@gpshead, @ncoghlan, @pitrou, @giampaolo, @tiran, @benjaminp, @alex, @dstufft
Dependencies	bpo-21304: PEP 466: Backport hashlib.pbkdf2_hmac to Python 2.7
Files	backport-hashlib.diff backport-hashlib.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-08-28.13:42:29.273>
created_at = <Date 2014-04-19.00:54:56.303>
labels = ['extension-modules', 'type-feature']
title = 'PEP 466: backport hashlib changes'
updated_at = <Date 2014-08-28.13:42:29.271>
user = 'https://github.com/ncoghlan'

bugs.python.org fields:

activity = <Date 2014-08-28.13:42:29.271>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-08-28.13:42:29.273>
closer = 'python-dev'
components = ['Extension Modules']
creation = <Date 2014-04-19.00:54:56.303>
creator = 'ncoghlan'
dependencies = ['21304']
files = ['36436', '36439']
hgrepos = []
issue_num = 21307
keywords = ['patch', 'needs review']
message_count = 10.0
messages = ['216827', '216828', '216829', '216833', '225683', '225720', '225721', '225722', '225886', '226023']
nosy_count = 10.0
nosy_names = ['gregory.p.smith', 'ncoghlan', 'janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'benjamin.peterson', 'alex', 'python-dev', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21307'
versions = ['Python 2.7']

[ncoghlan]

Tracker issue for the hashlib PBKDF2 and algorithm availability details backport to 2.7 described in PEP-466.

[alex]

bpo-21304 has the implementation of the PBKDF2 work.

[benjaminp]

Let's dup this then.

[benjaminp]

Rather bpo-21304 should be a dep...

[alex]

Uploaded patch adds the algorithm availability constants to the hashlib module.

[gpshead]

use a frozenset for algorithms_guaranteed.

in the docs under more algor... may be available make the two variables
link to their docs. you might explicitly mention python 2.7.9 in that
paragraph.

you probably should use pystring_fromstring imstead of unicode given this
is 2.7.

On Fri, Aug 22, 2014 at 9:46 AM, Alex Gaynor <report@bugs.python.org> wrote:

Alex Gaynor added the comment:

Uploaded patch adds the algorithm availability constants to the hashlib
module.

----------
components: +Extension Modules
keywords: +needs review, patch
Added file: http://bugs.python.org/file36436/backport-hashlib.diff

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue21307\>

---

[alex]

New patch uses PyString_FromString.

To the other two points:

1. Python3 uses a mutable set for both of these, any reason for Python2 to be inconsistent?

2. The docs in Python3 don't have this link either, I'm trying to minimize the delta; if you think there should be a link I'd prefer it be done in python3, and then I can backport that as well.

[gpshead]

Keeping the delta small makes sense. I'd use frozenset in 3 as well but its
unimportant. LGTM.

[dstufft]

This Look good to me. +1

[python-dev]

New changeset 3f73c44b1fd1 by Benjamin Peterson in branch '2.7':
PEP-466: backport hashlib algorithm constants (closes bpo-21307)
http://hg.python.org/cpython/rev/3f73c44b1fd1