Win32 compiler warning in PyBytes_Concat

[zware]

BPO	21442
Nosy	@pitrou, @vstinner, @tjguk, @zware

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zware'
closed_at = <Date 2014-05-06.16:45:01.044>
created_at = <Date 2014-05-05.19:16:52.443>
labels = ['type-bug', 'OS-windows', 'build']
title = 'Win32 compiler warning in PyBytes_Concat'
updated_at = <Date 2014-05-06.16:45:01.043>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2014-05-06.16:45:01.043>
actor = 'zach.ware'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2014-05-06.16:45:01.044>
closer = 'zach.ware'
components = ['Build', 'Windows']
creation = <Date 2014-05-05.19:16:52.443>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 21442
keywords = []
message_count = 5.0
messages = ['217942', '217980', '217992', '217993', '217995']
nosy_count = 6.0
nosy_names = ['pitrou', 'vstinner', 'tim.golden', 'nikratio', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21442'
versions = ['Python 3.5']

[zware]

Issue bpo-21377 introduced a compiler warning on Windows:

..\Objects\bytesobject.c(2824): warning C4018: '>' : signed/unsigned mismatch [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj]

[zware]

Declaring oldsize as Py_ssize_t instead of size_t at Objects/bytesobject.c:2812 takes care of the warning, but I'm not comfortable saying that's a correct change.

[tjguk]

Well PyBytes_GET_SIZE is documented as returning a Py_ssize_t so I'd say it's perfectly valid.

[python-dev]

New changeset 6234f4caba57 by Zachary Ware in branch 'default':
Issue bpo-21442: Fix MSVC compiler warning introduced by bpo-21377.
http://hg.python.org/cpython/rev/6234f4caba57

[zware]

I should have looked a little harder, thanks Tim!