concurrent.futures.ThreadPoolExecutor does not use a default value

[PCManticore]

BPO	21527
Nosy	@gvanrossum, @brianquinlan, @PCManticore, @MojoVampire
Files	concurrent_futures_workers.patch issue21527.patch: Update max_workers

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-09-02.17:39:27.734>
created_at = <Date 2014-05-18.22:47:47.410>
labels = ['type-feature', 'library']
title = 'concurrent.futures.ThreadPoolExecutor does not use a default value'
updated_at = <Date 2014-09-02.17:39:27.732>
user = 'https://github.com/PCManticore'

bugs.python.org fields:

activity = <Date 2014-09-02.17:39:27.732>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-09-02.17:39:27.734>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2014-05-18.22:47:47.410>
creator = 'Claudiu.Popa'
dependencies = []
files = ['35287', '36494']
hgrepos = []
issue_num = 21527
keywords = ['patch']
message_count = 5.0
messages = ['218763', '218840', '226032', '226212', '226278']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'bquinlan', 'Claudiu.Popa', 'python-dev', 'josh.r']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21527'
versions = ['Python 3.5']

[PCManticore]

As the title says, ThreadPoolExecutor does not use a default value for max_workers parameter, as ProcessPoolExecutor does. When the user does not care about the number of workers and wants only for something to run in background, he has to write code like this:

if processes:
   executor = ProcessPoolExecutor()
elif threads:
   executor = ThreadPoolExecutor(1) # or any other value

This situation can also occur when the class is passed as a factory function:

def create_pool(executor_factory):
   if executor_factory is process pool:
       executor = executor_factory()
   else:
       executor = executor_factory(1)

This patch proposes using the number of cores as the default value for max_workers.
For instance, multiprocessing.pool.ThreadPool uses the same value.

[MojoVampire]

+1. Makes it easier to swap Executors (which is a big selling point for the Executor framework), and number of cores is a reasonable default value.

[gvanrossum]

Looks good.

[PCManticore]

Thank you, Guido.

[python-dev]

New changeset 2805b0dca798 by Guido van Rossum in branch 'default':
Closes bpo-21527: Add default number of workers to ThreadPoolExecutor. (Claudiu Popa.)
http://hg.python.org/cpython/rev/2805b0dca798