Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the members parameter for TarFile.list() #65748

Closed
serhiy-storchaka opened this issue May 21, 2014 · 5 comments
Closed

Add the members parameter for TarFile.list() #65748

serhiy-storchaka opened this issue May 21, 2014 · 5 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 21, 2014

BPO 21549
Nosy @gustaebel, @serhiy-storchaka
Files
  • tarfile_list_members_2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2014-08-21.07:10:55.270>
    created_at = <Date 2014-05-21.10:30:23.729>
    labels = ['type-feature', 'library']
    title = 'Add the members parameter for TarFile.list()'
    updated_at = <Date 2014-08-21.07:10:55.268>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-08-21.07:10:55.268>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2014-08-21.07:10:55.270>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2014-05-21.10:30:23.729>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['36398']
    hgrepos = []
    issue_num = 21549
    keywords = ['patch']
    message_count = 5.0
    messages = ['218866', '218868', '225452', '225602', '225603']
    nosy_count = 3.0
    nosy_names = ['lars.gustaebel', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue21549'
    versions = ['Python 3.5']

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented May 21, 2014

    The proposed patch adds the members parameter for TarFile.list() with the same meaning as in TarFile.extractall(). This is needed for implementing the tar command utility which allows filtering and transforming an output (e.g. output numerical ids instead names for owner/group).

    An alternative approach is to add the filter parameter (as in TarFile.add()) to both TarFile.list() and TarFile.extractall().

    @serhiy-storchaka serhiy-storchaka added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 21, 2014
    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented May 21, 2014

    See bpo-21550 for example.

    @serhiy-storchaka serhiy-storchaka self-assigned this Aug 17, 2014
    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Aug 17, 2014

    Added a test. Make the members parameter keyword-only.

    If there are no objections I'll commit the patch soon.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 21, 2014

    New changeset 5875c50e93fe by Serhiy Storchaka in branch 'default':
    Issue bpo-21549: Added the "members" parameter to TarFile.list().
    http://hg.python.org/cpython/rev/5875c50e93fe

    @serhiy-storchaka
    Copy link
    Member Author

    serhiy-storchaka commented Aug 21, 2014

    Thank you Berker for the review.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant