Exclusive mode for ZipFile and TarFile

[anntzer]

BPO	21717
Nosy	@gustaebel, @berkerpeksag, @serhiy-storchaka, @anntzer
Files	issue21717_tarfile.diff issue21717_v2.diff zipfile_mode_x.patch issue21717_tarfile_v3.diff issue21717_tarfile_v4.diff issue21717_tarfile_v5.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-03-25.08:11:46.943>
created_at = <Date 2014-06-11.10:26:20.641>
labels = ['type-feature', 'library']
title = 'Exclusive mode for ZipFile and TarFile'
updated_at = <Date 2015-03-25.08:11:46.942>
user = 'https://github.com/anntzer'

bugs.python.org fields:

activity = <Date 2015-03-25.08:11:46.942>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-03-25.08:11:46.943>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-06-11.10:26:20.641>
creator = 'Antony.Lee'
dependencies = []
files = ['35740', '38025', '38027', '38081', '38095', '38115']
hgrepos = []
issue_num = 21717
keywords = ['patch']
message_count = 12.0
messages = ['220249', '221358', '235454', '235478', '235482', '235488', '235679', '235912', '235913', '239149', '239231', '239235']
nosy_count = 5.0
nosy_names = ['lars.gustaebel', 'python-dev', 'berker.peksag', 'serhiy.storchaka', 'Antony.Lee']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21717'
versions = ['Python 3.5']

[anntzer]

I noticed that while lzma and bz2 already support the "x" (create a new file, raise if it already exists) flag, zipfile and tarfile don't know about it yet. It would be an useful addition, just as it is useful for regular open.

A quick look at both modules show that this likely only requires a little bit more than updating the checks in the corresponding constructors to allow "x" mode, as the modes are passed (nearly) transparently to the open() builtin.

[berkerpeksag]

Here's a patch for tarfile.

[serhiy-storchaka]

Ping.

[berkerpeksag]

Here's an updated patch. Thanks Serhiy.

[serhiy-storchaka]

Added more comments.

[serhiy-storchaka]

Here is a patch for zipfile.

[berkerpeksag]

Updated patch. Thanks again, Serhiy.

[python-dev]

New changeset ed9e9e6b3c1e by Berker Peksag in branch 'default':
Issue bpo-21717: tarfile.open() now supports 'x' (exclusive creation) mode.
https://hg.python.org/cpython/rev/ed9e9e6b3c1e

[berkerpeksag]

Thanks for the review, Serhiy. I'll take a look at the zipfile patch tomorrow.

[serhiy-storchaka]

Could you look on zipfile patch Berker? It is simpler than tarfile patch.

[berkerpeksag]

LGTM. I left two minor comments on Rietveld. Sorry for the delay.

[python-dev]

New changeset b2a8c30d8ddb by Serhiy Storchaka in branch 'default':
Issue bpo-21717: The zipfile.ZipFile.open function now supports 'x' (exclusive
https://hg.python.org/cpython/rev/b2a8c30d8ddb