smtpd.SMTPServer should announce 8BITMIME when supported and accept SMTPUTF8 without it

[zvyn]

BPO	21795
Nosy	@warsaw, @pitrou, @bitdancer, @zvyn
Files	issue21795.patch issue21795v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-05-11.16:13:11.590>
created_at = <Date 2014-06-17.19:30:01.412>
labels = ['type-feature', 'expert-email']
title = 'smtpd.SMTPServer should announce 8BITMIME when supported and accept SMTPUTF8 without it'
updated_at = <Date 2015-05-11.16:13:11.589>
user = 'https://github.com/zvyn'

bugs.python.org fields:

activity = <Date 2015-05-11.16:13:11.589>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2015-05-11.16:13:11.590>
closer = 'r.david.murray'
components = ['email']
creation = <Date 2014-06-17.19:30:01.412>
creator = 'zvyn'
dependencies = []
files = ['36360', '36370']
hgrepos = []
issue_num = 21795
keywords = ['patch']
message_count = 7.0
messages = ['220868', '225225', '225236', '225300', '225308', '242900', '242901']
nosy_count = 6.0
nosy_names = ['barry', 'pitrou', 'r.david.murray', 'jesstess', 'python-dev', 'zvyn']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21795'
versions = ['Python 3.5']

[zvyn]

The smtpd.SMTPServer does support 8BITMIME if decode_date is False (bpo-19662) and could be announced under this condition. The patch for bpo-21725 already implements 8BITMIME so this can easily be done afterwards.

[zvyn]

Also the server should accept the SMTPUTF8 mail argument completely independently of 8BITMIME if both are enabled.

[zvyn]

The proposed patch extends process_message with an **kwargs catch-all which is filled with 'mail_options' and 'rcpt_options' if decode_data is False. I also removed process_smtputf8_message as one can detect the need for supporting SMTPUTF8 from kwargs['mail_options'] now.
8BITMIE is accepted if decode_data=False and SMTPUTF8 is accepted if enable_SMTPUTF8=True (which implies decode_data=False).

[bitdancer]

Added some review comments.

[zvyn]

Thanks, for the review, here's comes an updated version.

[python-dev]

New changeset e34ed02738bf by R David Murray in branch 'default':
bpo-21795: advertise 8BITMIME if decode_data is False.
https://hg.python.org/cpython/rev/e34ed02738bf

[bitdancer]

Thanks, Milan. I tweaked some things and tried to sort out the docs for all the changes we have made to smtpd. If you see anything I screwed up let me know.