-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
urllib.request.urlopen should take a "context" (SSLContext) argument #66562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Instead of the ca* arguments it currently takes, these can all be encapsulated into an SSLContext argument, which the underlying http.client already supports. |
Attached patch against the default branch adds support for this. |
Added a versionchanged directive to the docs. |
New patch switches to a ValueError and includes a test case that it's raised. |
With the final review comment addressed, this could go in. Since you have commit rights, please feel free to commit it. (else, please assign this to me and I will commit and follow up with the buildbots) |
Replied to the review; let me know if you agree with my comment. |
Just wanted to ping you on this Senthil about committing this. |
New changeset c0b0dda16009 by Senthil Kumaran in branch 'default': |
Committed this in 3.5. (Since this is adding an new argument, it should not be backported to 3.4). Thank you! |
My worry is not about the timing. I can add it immediately, but are we convinced on having a new argument (API Change) for 3.4.2 ? |
New changeset 9c3249b358d0 by Alex Gaynor in branch 'default': |
New changeset 13f46fc1a002 by Senthil Kumaran in branch '3.4': |
Please update versionchanged to 3.4.3 on default branch. |
New changeset 1882157b298a by Benjamin Peterson in branch '2.7': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: