Feature Request CAN_RAW_FD_FRAMES

[rumpelsepp]

BPO	22631
Nosy	@doko42, @pitrou, @larryhastings, @benjaminp, @bitdancer, @berkerpeksag, @rumpelsepp, @llllllllll
Files	CAN_RAW_FD_FRAMES.patch CAN_RAW_FD_FRAMES-update.patch CAN_RAW_FD_FRAMES-doc.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = <Date 2015-04-13.21:49:43.309>
created_at = <Date 2014-10-14.14:21:28.462>
labels = ['type-feature', 'library']
title = 'Feature Request CAN_RAW_FD_FRAMES'
updated_at = <Date 2015-04-14.18:10:37.564>
user = 'https://github.com/rumpelsepp'

bugs.python.org fields:

activity = <Date 2015-04-14.18:10:37.564>
actor = 'r.david.murray'
assignee = 'larry'
closed = True
closed_date = <Date 2015-04-13.21:49:43.309>
closer = 'larry'
components = ['Library (Lib)']
creation = <Date 2014-10-14.14:21:28.462>
creator = 'rumpelsepp'
dependencies = []
files = ['38934', '38946', '38957']
hgrepos = []
issue_num = 22631
keywords = ['patch']
message_count = 17.0
messages = ['229289', '229339', '240662', '240663', '240680', '240709', '240716', '240723', '240736', '240773', '240774', '240799', '240841', '240957', '240958', '240959', '240969']
nosy_count = 10.0
nosy_names = ['doko', 'pitrou', 'larry', 'benjamin.peterson', 'r.david.murray', 'neologix', 'python-dev', 'berker.peksag', 'rumpelsepp', 'llllllllll']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22631'
versions = ['Python 3.5']

[rumpelsepp]

CAN support was introduced with issue bpo-10141. Python still seems to lack support for CAN FD which is available with the socket option CAN_RAW_FD_FRAMES, see here (chapter 4.1.5): https://www.kernel.org/doc/Documentation/networking/can.txt

[neologix]

Annoying.
I thought CAN_RAW_FD_FRAME would be a macro, which would have made conditional compilation easy, but it's apparently a enum value, which means we have to add a configure-time check...

[llllllllll]

I have added a patch to update this with conditional compilation.

[llllllllll]

To show where I got my sources: torvalds/linux@e2d265d

There does not appear to be any new structures needed other than supporting the constant.

[larryhastings]

LGTM, just adding Antoine (the expert for the socket module). I'm ready to commit over here.

[berkerpeksag]

The new constant should probably be added to https://docs.python.org/3/library/socket.html#constants (with a .. versionadded:: 3.5 directive)

[llllllllll]

I am not going to be able to write docs on this because I am not totally sure how you would use this; There is an entry in the docs for CAN_* so that might be enough. I have a line now saying that this particular flag is available as of 3.5 though.

[larryhastings]

Follow the instructions in this:

https://docs.python.org/devguide/docquality.html

And make it look something like this:

https://docs.python.org/3/library/socket.html#socket.CAN_BCM

[llllllllll]

I tried to provide a summary of the Linux page on the topic and then said that it was fully documented there.

[python-dev]

New changeset 03ff92b26fa9 by Larry Hastings in branch 'default':
Issue bpo-22631: Added Linux-specific socket constant CAN_RAW_FD_FRAMES.
https://hg.python.org/cpython/rev/03ff92b26fa9

[larryhastings]

Patch committed. Thanks, Joe!

[doko42]

it would be nice to have these constants backported to both 2.7 and 3.4. It may be good to check for other missing consgtants in this module in 2.7 and 3.4.

[llllllllll]

So I think the patch could be applied to 3.4; I will look into moving the other back sometime this week.

[larryhastings]

Isn't this a "new feature"? 2.7 is maybe fair game, but 3.4 arguably is not.

It should be odd to have a field marked in the documentation as "New in 3.4.4."

[pitrou]

It is a new feature.

[larryhastings]

Benjamin, would you like CAN_RAW_FD_FRAMES in the next 2.7?

[bitdancer]

There is no CAN support in 2.7, so no.