SimpleCookie not unpicklable with protocol 2+

[timgraham]

BPO	22775
Nosy	@birkenfeld, @berkerpeksag, @serhiy-storchaka, @timgraham
Files	cookie-pickle-highest.diff cookie-pickling-all-protocols.diff cookie-pickling-all-protocols-2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-11-02.20:24:49.309>
created_at = <Date 2014-10-31.16:58:03.444>
labels = ['type-bug', 'library']
title = 'SimpleCookie not unpicklable with protocol 2+'
updated_at = <Date 2014-11-04.07:47:25.522>
user = 'https://github.com/timgraham'

bugs.python.org fields:

activity = <Date 2014-11-04.07:47:25.522>
actor = 'georg.brandl'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-11-02.20:24:49.309>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-10-31.16:58:03.444>
creator = 'Tim.Graham'
dependencies = []
files = ['37088', '37100', '37114']
hgrepos = []
issue_num = 22775
keywords = ['patch']
message_count = 11.0
messages = ['230354', '230355', '230436', '230452', '230516', '230520', '230521', '230522', '230523', '230524', '230587']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'Arfrever', 'python-dev', 'berker.peksag', 'serhiy.storchaka', 'Tim.Graham']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22775'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[timgraham]

Expected:

>>> import pickle
>>> from http.cookies import SimpleCookie
>>> pickle.loads(pickle.dumps(SimpleCookie('hi=there'),2))
<SimpleCookie: hi='there'>
# Actual
<SimpleCookie: hi='Set-Cookie: hi=there'>

Patch is based on the suggestion from Georg Brandl in bpo-22758 (I added the "else" as the fix did not work without it).

[timgraham]

By the way, this is my first patch for Python and I submitted a CLA 2 days ago.

[serhiy-storchaka]

Test pickling with all protocols (see bpo-22777), not only with HIGHEST_PROTOCOL.

[timgraham]

Updated patch to test pickling of all protocols.

[timgraham]

Updated patch per comments.

[serhiy-storchaka]

LGTM.

[python-dev]

New changeset 7be6ef737aaf by Serhiy Storchaka in branch '3.4':
Issue bpo-22775: Fixed unpickling of http.cookies.SimpleCookie with protocol 2
https://hg.python.org/cpython/rev/7be6ef737aaf

New changeset caa8f9248ab8 by Serhiy Storchaka in branch 'default':
Issue bpo-22775: Fixed unpickling of http.cookies.SimpleCookie with protocol 2
https://hg.python.org/cpython/rev/caa8f9248ab8

[serhiy-storchaka]

Thank you for your contribution Tim.

[python-dev]

New changeset 515331e0ca0c by Serhiy Storchaka in branch '2.7':
Issue bpo-22775: Fixed unpickling of Cookie.SimpleCookie with protocol 2.
https://hg.python.org/cpython/rev/515331e0ca0c

[serhiy-storchaka]

This affects 2.7 too.

[birkenfeld]

Thanks!