allow logging.handlers.HTTPHandler to take an SSLContext

[benjaminp]

BPO	22788
Nosy	@vsajip, @benjaminp, @alex
Files	issue22788.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-11-24.02:38:30.858>
created_at = <Date 2014-11-03.18:49:27.535>
labels = ['type-feature', 'library']
title = 'allow logging.handlers.HTTPHandler to take an SSLContext'
updated_at = <Date 2014-11-24.02:38:30.856>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2014-11-24.02:38:30.856>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-11-24.02:38:30.858>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2014-11-03.18:49:27.535>
creator = 'benjamin.peterson'
dependencies = []
files = ['37124']
hgrepos = []
issue_num = 22788
keywords = ['patch', 'needs review']
message_count = 7.0
messages = ['230549', '230551', '230552', '230553', '230555', '230558', '231589']
nosy_count = 5.0
nosy_names = ['vinay.sajip', 'benjamin.peterson', 'Arfrever', 'alex', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22788'
versions = ['Python 3.5']

[benjaminp]

It would be nice if HTTPHandler could take an SSLContext as a parameter, which would be passed to HTTPSConnection to configure the security of the connection.

[alex]

I'm not sure I follow, where does HTTPHandler ever construct an HTTPSConnection?

[benjaminp]

emit()

On Mon, Nov 3, 2014, at 15:33, Alex Gaynor wrote:

Alex Gaynor added the comment:

I'm not sure I follow, where does HTTPHandler ever construct an
HTTPSConnection?

----------
nosy: +alex

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue22788\>

---

[alex]

Hah! I didn't realize you meant *logging.handlers.HTTPHandler*, I thought you meant *urllib.request.HTTPHandler*.

[benjaminp]

Right then...

[alex]

Quick pass at a patch. No docs, and it should proabbly be an error to pass context with secure=False.

[python-dev]

New changeset 5864ec6ba484 by Benjamin Peterson in branch '3.4':
add context parameter to HTTPHandler (closes bpo-22788)
https://hg.python.org/cpython/rev/5864ec6ba484

New changeset ec4d19736b15 by Benjamin Peterson in branch 'default':
merge 3.4 (bpo-22788)
https://hg.python.org/cpython/rev/ec4d19736b15