Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow logging.handlers.HTTPHandler to take an SSLContext #66977

Closed
benjaminp opened this issue Nov 3, 2014 · 7 comments
Closed

allow logging.handlers.HTTPHandler to take an SSLContext #66977

benjaminp opened this issue Nov 3, 2014 · 7 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@benjaminp
Copy link
Contributor

benjaminp commented Nov 3, 2014

BPO 22788
Nosy @vsajip, @benjaminp, @alex
Files
  • issue22788.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2014-11-24.02:38:30.858>
    created_at = <Date 2014-11-03.18:49:27.535>
    labels = ['type-feature', 'library']
    title = 'allow logging.handlers.HTTPHandler to take an SSLContext'
    updated_at = <Date 2014-11-24.02:38:30.856>
    user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2014-11-24.02:38:30.856>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2014-11-24.02:38:30.858>
    closer = 'python-dev'
    components = ['Library (Lib)']
    creation = <Date 2014-11-03.18:49:27.535>
    creator = 'benjamin.peterson'
    dependencies = []
    files = ['37124']
    hgrepos = []
    issue_num = 22788
    keywords = ['patch', 'needs review']
    message_count = 7.0
    messages = ['230549', '230551', '230552', '230553', '230555', '230558', '231589']
    nosy_count = 5.0
    nosy_names = ['vinay.sajip', 'benjamin.peterson', 'Arfrever', 'alex', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22788'
    versions = ['Python 3.5']

    @benjaminp
    Copy link
    Contributor Author

    benjaminp commented Nov 3, 2014

    It would be nice if HTTPHandler could take an SSLContext as a parameter, which would be passed to HTTPSConnection to configure the security of the connection.

    @benjaminp benjaminp added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Nov 3, 2014
    @alex
    Copy link
    Member

    alex commented Nov 3, 2014

    I'm not sure I follow, where does HTTPHandler ever construct an HTTPSConnection?

    @benjaminp
    Copy link
    Contributor Author

    benjaminp commented Nov 3, 2014

    emit()

    On Mon, Nov 3, 2014, at 15:33, Alex Gaynor wrote:

    Alex Gaynor added the comment:

    I'm not sure I follow, where does HTTPHandler ever construct an
    HTTPSConnection?

    ----------
    nosy: +alex


    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue22788\>


    @alex
    Copy link
    Member

    alex commented Nov 3, 2014

    Hah! I didn't realize you meant *logging.handlers.HTTPHandler*, I thought you meant *urllib.request.HTTPHandler*.

    @benjaminp
    Copy link
    Contributor Author

    benjaminp commented Nov 3, 2014

    Right then...

    @benjaminp benjaminp changed the title allow HTTPHandler to take an SSLContext allow logging.handlers.HTTPHandler to take an SSLContext Nov 3, 2014
    @alex
    Copy link
    Member

    alex commented Nov 3, 2014

    Quick pass at a patch. No docs, and it should proabbly be an error to pass context with secure=False.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 24, 2014

    New changeset 5864ec6ba484 by Benjamin Peterson in branch '3.4':
    add context parameter to HTTPHandler (closes bpo-22788)
    https://hg.python.org/cpython/rev/5864ec6ba484

    New changeset ec4d19736b15 by Benjamin Peterson in branch 'default':
    merge 3.4 (bpo-22788)
    https://hg.python.org/cpython/rev/ec4d19736b15

    @python-dev python-dev mannequin closed this as completed Nov 24, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants