Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose the client's list of ciphers during the handshake #67375

Closed
benjaminp opened this issue Jan 7, 2015 · 3 comments
Closed

expose the client's list of ciphers during the handshake #67375

benjaminp opened this issue Jan 7, 2015 · 3 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@benjaminp
Copy link
Contributor

benjaminp commented Jan 7, 2015

BPO 23186
Nosy @pitrou, @vstinner, @giampaolo, @tiran, @benjaminp, @alex, @dstufft
Files
  • shared-ciphers.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-01-07.19:13:02.511>
    created_at = <Date 2015-01-07.17:01:02.511>
    labels = ['type-feature', 'library']
    title = "expose the client's list of ciphers during the handshake"
    updated_at = <Date 2015-01-07.19:13:02.510>
    user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2015-01-07.19:13:02.510>
    actor = 'benjamin.peterson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-01-07.19:13:02.511>
    closer = 'benjamin.peterson'
    components = ['Library (Lib)']
    creation = <Date 2015-01-07.17:01:02.511>
    creator = 'benjamin.peterson'
    dependencies = []
    files = ['37630']
    hgrepos = []
    issue_num = 23186
    keywords = ['patch']
    message_count = 3.0
    messages = ['233584', '233586', '233587']
    nosy_count = 9.0
    nosy_names = ['janssen', 'pitrou', 'vstinner', 'giampaolo.rodola', 'christian.heimes', 'benjamin.peterson', 'alex', 'python-dev', 'dstufft']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue23186'
    versions = ['Python 3.5']

    @benjaminp
    Copy link
    Contributor Author

    benjaminp commented Jan 7, 2015

    This patch adds a shared_ciphers() method to SSLObject and SSLSocket, which allows servers to see the complete list of ciphers sent by the client during handshake.

    @benjaminp benjaminp added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 7, 2015
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 7, 2015

    New changeset bc34fcccaca3 by Benjamin Peterson in branch 'default':
    expose the client's cipher suites from the handshake (closes bpo-23186)
    https://hg.python.org/cpython/rev/bc34fcccaca3

    @python-dev python-dev mannequin closed this as completed Jan 7, 2015
    @vstinner
    Copy link
    Member

    vstinner commented Jan 7, 2015

    I reopen the issue because you commit your change while I was reviewing the patch :-/ See my review at Rietveld.

    @vstinner vstinner reopened this Jan 7, 2015
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants