You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee=Noneclosed_at=<Date2016-02-22.09:07:41.876>created_at=<Date2015-02-10.03:34:07.961>labels= ['type-feature', 'library']
title='socketserver.BaseServer.handle_error() should not catch exiting exceptions'updated_at=<Date2016-02-22.09:07:41.875>user='https://github.com/vadmium'
I propose changing the socket servers to not suppress exceptions that are meant to exit the interpreter. This is most applicable to single threaded servers, but my patch does the same thing for multithreading servers. It no longer catches exceptions that are not derived from the Exception class, such as KeyboardInterrupt and SystemExit. The shutdown_request() method is still called in all cases though.
I also added a test for the forking server’s handle_error() method.