gzip argparse interface

[anntzer]

BPO	23596
Nosy	@berkerpeksag, @matrixise, @JulienPalard, @miss-islington, @tirkarthi
PRs	bpo-23596: Add unit tests for the command line for the gzip module #9775 [3.7] bpo-23596: Add unit tests for the command line for the gzip module (GH-9775) #9779 [3.6] bpo-23596: Add unit tests for the command line for the gzip module (GH-9775) #9780 bpo-23596: Use argparse for the command line of gzip #9781
Files	gzip-argparse-cli.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-09.22:45:13.756>
created_at = <Date 2015-03-06.00:54:31.118>
labels = ['3.7', '3.8', 'type-feature', 'library']
title = 'gzip argparse interface'
updated_at = <Date 2018-10-10.06:49:12.807>
user = 'https://github.com/anntzer'

bugs.python.org fields:

activity = <Date 2018-10-10.06:49:12.807>
actor = 'mdk'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-09.22:45:13.756>
closer = 'matrixise'
components = ['Library (Lib)']
creation = <Date 2015-03-06.00:54:31.118>
creator = 'Antony.Lee'
dependencies = []
files = ['38353']
hgrepos = []
issue_num = 23596
keywords = ['patch']
message_count = 10.0
messages = ['237315', '237322', '327426', '327432', '327437', '327438', '327439', '327440', '327442', '327443']
nosy_count = 5.0
nosy_names = ['berker.peksag', 'matrixise', 'mdk', 'miss-islington', 'xtreak']
pr_nums = ['9775', '9779', '9780', '9781']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23596'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[anntzer]

The attached patch reimplements gzip's already existing command-line interface using argparse, both to provide command-line help and to avoid manual argument parsing.

[berkerpeksag]

Thanks for the patch, but we need to add tests for the current CLI to make sure that we don't break anything when we apply gzip-argparse-cli.patch. See Lib/test/test_tarfile.py and Lib/test/test_calendar.py for example CLI tests.

[matrixise]

Hi Berker,

Here is my PR for this issue.

From this PR, I will add the new CLI with argparse.

And after this issue, I will work on https://bugs.python.org/issue34913

[tirkarthi]

Thanks @matrixise for the PR. This seems to be a good first step for both testing the command line interface and also argparse can generate help string which can be used for bpo-34913.

[JulienPalard]

New changeset 84eec11 by Julien Palard (Stéphane Wirtel) in branch 'master':
bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)
84eec11

[matrixise]

And now, I am going to work on the refactoring with argparse

[miss-islington]

New changeset 482dc94 by Miss Islington (bot) in branch '3.6':
bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)
482dc94

[miss-islington]

New changeset 8e23ba0 by Miss Islington (bot) in branch '3.7':
bpo-23596: Add unit tests for the command line for the gzip module (GH-9775)
8e23ba0

[JulienPalard]

New changeset e8bbc52 by Julien Palard (Stéphane Wirtel) in branch 'master':
bpo-23596: Use argparse for the command line of gzip (GH-9781)
e8bbc52

[matrixise]

I have added some tests for 3.6, 3.7 and 3.8.

But for the new CLI, just for 3.8

now, I am going to close this issue.