Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkinter canvas lacks of moveto method. #68019

Closed
mps mannequin opened this issue Mar 31, 2015 · 6 comments
Closed

tkinter canvas lacks of moveto method. #68019

mps mannequin opened this issue Mar 31, 2015 · 6 comments
Labels
3.8 only security fixes topic-tkinter type-feature A feature request or enhancement

Comments

@mps
Copy link
Mannequin

mps mannequin commented Mar 31, 2015

BPO 23831
Nosy @terryjreedy, @mkiever, @serhiy-storchaka, @zaazbb, @j4321
PRs
  • bpo-23831: Add moveto method to the tkinter.Canvas widget #9768
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-10-12.16:44:47.496>
    created_at = <Date 2015-03-31.20:15:32.085>
    labels = ['3.8', 'type-feature', 'expert-tkinter']
    title = 'tkinter canvas lacks of moveto method.'
    updated_at = <Date 2018-10-12.16:44:47.496>
    user = 'https://bugs.python.org/mps'

    bugs.python.org fields:

    activity = <Date 2018-10-12.16:44:47.496>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-10-12.16:44:47.496>
    closer = 'serhiy.storchaka'
    components = ['Tkinter']
    creation = <Date 2015-03-31.20:15:32.085>
    creator = 'mps'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 23831
    keywords = ['patch']
    message_count = 6.0
    messages = ['239745', '273850', '327399', '327400', '327435', '327597']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'mkiever', 'serhiy.storchaka', 'zaazbb', 'mps', 'j-4321-i']
    pr_nums = ['9768']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue23831'
    versions = ['Python 3.8']

    @mps
    Copy link
    Mannequin Author

    mps mannequin commented Mar 31, 2015

    I apologize if it has already been reported but I was unable to find similar issue reported using "search".

    Maybe just add:
    def moveto(self, tagOrId, xPos, yPos):
    """Move the items given by tagOrId in the canvas coordinate
    space so that the first coordinate pair of the bottommost
    item with tag tagOrId is located at position (xPos,yPos).
    xPos and yPos may be the empty string, in which case the
    corresponding coordinate will be unchanged. All items matching
    tagOrId remain in the same positions relative to each other.
    This command returns an empty string.
    """
    return self.tk.call(self._w, 'moveto', tagOrId, xPos, yPos)

    @mps mps mannequin added topic-tkinter type-feature A feature request or enhancement labels Mar 31, 2015
    @zaazbb
    Copy link
    Mannequin

    zaazbb mannequin commented Aug 29, 2016

    i met the same problem, when i translate knighstour.tcl(upder tk demos dir) to tkinter.

    @j4321
    Copy link
    Mannequin

    j4321 mannequin commented Oct 9, 2018

    I am willing to create a pull request with the code provided in msg239745 , to add tests and a what's new entry. However I am not sure about how to acknowledge the contribution of msg239745's author.

    @serhiy-storchaka
    Copy link
    Member

    I think you can be attributed as the only author. A PR should contain more than just changes in tkinter/init.py (tests, documentation changes). And the code can be different than proposed in msg239745. Since this command doesn't return anything meaningful, I suggest to remove "return" and the last sentence in the docstring.

    @serhiy-storchaka serhiy-storchaka added the 3.8 only security fixes label Oct 9, 2018
    @terryjreedy
    Copy link
    Member

    +1 on adding this.

    We can and sometimes do acknowledge an initial author in the commit message and blurb. In this case, there is no name, so it would be "Based on patch by 'mps'."

    @serhiy-storchaka
    Copy link
    Member

    New changeset bf03471 by Serhiy Storchaka (Juliette Monsel) in branch 'master':
    bpo-23831: Add moveto method to the tkinter.Canvas widget. (GH-9768)
    bf03471

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes topic-tkinter type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants