[PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS

[andyjs]

BPO	23895
Nosy	@jcea, @bitdancer
Files	solaris-socket-zignore.diff: Patch which pulls in libsocket and libnsl when building on Solaris socket.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2015-04-09.13:43:05.613>
labels = ['build']
title = '[PATCH] python socket module fails to build on Solaris when -zignore is in LDFLAGS'
updated_at = <Date 2015-11-17.15:20:14.403>
user = 'https://bugs.python.org/andyjs'

bugs.python.org fields:

activity = <Date 2015-11-17.15:20:14.403>
actor = 'andy_js'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2015-04-09.13:43:05.613>
creator = 'andy_js'
dependencies = []
files = ['38877', '39539']
hgrepos = []
issue_num = 23895
keywords = ['patch']
message_count = 8.0
messages = ['240325', '242950', '242969', '244318', '244324', '244325', '245380', '254801']
nosy_count = 4.0
nosy_names = ['jcea', 'r.david.murray', 'andy_js', 'Alexander.Pyhalov']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'languishing'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23895'
versions = ['Python 2.7']

[andyjs]

The socket module fails to build when -zignore is in LDFLAGS. This option changes the linker behaviour so it will only resolve against the libraries linked in explicitly instead of doing resolution recursively against their dependencies too.

[andyjs]

Bump.

Would be nice to get this included in python 2.7.11.

I also have a similar fix for the multiprocessing module but I won't bother submitting it if it will get ignored.

[bitdancer]

Do you know anyone else using solaris who could do a review (ie: confirm that your patch makes sense and works for them)? It looks like jcea, who is our only current committer who uses Solaris as far as I know (well, OpenIndiana), hasn't had time to look at this.

On the other hand, it isn't 100% clear to me that this is appropriate. I'm not (yet) experienced enough with the internals of our build system to be the one to make the call, but it seems to me that you can support -z ignore by modifying your Modules/Setup file, so it may not be appropriate to inject solaris specific support in setup.py for an option that isn't normally used.

[andyjs]

The -z ignore option is actually exposing issues that could cause a problem at runtime. If the socket module were imported and libsocket/libnsl hadn't already been loaded (i.e pulled in by the loader as a dependency of another module) the loader would fail due to unresolved symbols.

This problem would not effect Linux because all of the socket stuff is in libc, which is not the case on Solaris. Today it doesn't cause a problem because most other things are already pulling in libsocket and libnsl before the socket module is loaded, but there's no guarantee that will always be the case.

For the sake of correctness it should be fixed, and I would suggest later making -z ignore the default on Solaris.

I will see if I can find somebody else to review the patch.

[AlexanderPyhalov]

We have similar patch here in OpenIndiana. The patch is correct.

[AlexanderPyhalov]

BTW, we use the following version for Python 3.4

[andyjs]

Bump.

[andyjs]

Bump.