Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC 6532 support to the email library #68399

Closed
bitdancer opened this issue May 16, 2015 · 5 comments
Closed

Add RFC 6532 support to the email library #68399

bitdancer opened this issue May 16, 2015 · 5 comments
Labels
expert-email type-feature A feature request or enhancement

Comments

@bitdancer
Copy link
Member

bitdancer commented May 16, 2015

BPO 24211
Nosy @warsaw, @bitdancer, @soltysh
Files
  • email_smtputf8.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-05-17.16:17:21.632>
    created_at = <Date 2015-05-16.21:19:09.918>
    labels = ['type-feature', 'expert-email']
    title = 'Add RFC 6532 support to the email library'
    updated_at = <Date 2015-05-17.23:38:15.623>
    user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2015-05-17.23:38:15.623>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-05-17.16:17:21.632>
    closer = 'r.david.murray'
    components = ['email']
    creation = <Date 2015-05-16.21:19:09.918>
    creator = 'r.david.murray'
    dependencies = []
    files = ['39397']
    hgrepos = []
    issue_num = 24211
    keywords = ['patch']
    message_count = 5.0
    messages = ['243368', '243403', '243408', '243412', '243432']
    nosy_count = 4.0
    nosy_names = ['barry', 'r.david.murray', 'python-dev', 'maciej.szulik']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue24211'
    versions = ['Python 3.5']

    @bitdancer
    Copy link
    Member Author

    bitdancer commented May 16, 2015

    I could have sworn there was an issue for this already, but I couldn't find it.

    Attached patch adds a utf8 policy knob and an SMTPUTF8 policy instance, and modifies BytesGenerator and the _header_value_parser to use that policy setting to generate utf8 headers instead of encoding non-ascii using encoded words. (I designed the new code to make it easy to support this RFC, but even I had no idea the patch would be so small. I hope I didn't miss anything.)

    I will probably commit this tomorrow, since the deadline is looming.

    @bitdancer bitdancer added expert-email type-feature A feature request or enhancement labels May 16, 2015
    @soltysh
    Copy link

    soltysh commented May 17, 2015

    David one small nit in docs, but otherwise the patch looks good, applies cleanly and works as expected.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 17, 2015

    New changeset 9f0d5e33230f by R David Murray in branch 'default':
    bpo-24211: Add RFC6532 support to the email library.
    https://hg.python.org/cpython/rev/9f0d5e33230f

    @bitdancer
    Copy link
    Member Author

    bitdancer commented May 17, 2015

    Thanks, Maciej.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented May 17, 2015

    New changeset 4a254750ad20 by R David Murray in branch 'default':
    bpo-24211: Add missing docs for SMTPUTF8 policy instance.
    https://hg.python.org/cpython/rev/4a254750ad20

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    expert-email type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants