You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee=Noneclosed_at=<Date2018-06-27.18:07:13.045>created_at=<Date2015-09-05.10:42:33.328>labels= ['3.8', 'type-feature', 'library']
title='Add support of copy protocol to zlib compressors and decompressors'updated_at=<Date2018-06-27.18:07:13.044>user='https://github.com/serhiy-storchaka'
Patch looks good, but incomplete. Supporting __deepcopy__ (as a simple wrapper around __copy__ that ignores the second argument) would provide complete support.
Also, should there be tests? I mean, I assume the .copy() method itself is tested, but just to detect stupid regressions, seems like testing __copy__/deepcopy for identical behavior would be a good thing.
I agree with Josh. Needed __deepcopy__ and tests. And I think there may be problem with sharing a docstring (that includes a signature) between copy() and __copy__(). It is better to just add separate method that calls the implementation of copy().