Add support for CAN_RAW_JOIN_FILTERS

[rumpelsepp]

BPO	25780
Nosy	@bitdancer, @vadmium, @rumpelsepp, @ZackerySpytz, @pablogsal
PRs	bpo-25780: Expose CAN_RAW_JOIN_FILTERS in the socket module #19190
Files	can_raw_join_filters.diff: patch for CAN_RAW_JOIN_FILTERS; with trailing whitespace cleanup can_raw_join_filters-no-whitespace.diff: patch for CAN_RAW_JOIN_FILTERS; without trailing whitespace cleanup can_raw_join_filters-no-whitespace-v2.diff: patch for CAN_RAW_JOIN_FILTERS; without trailing whitespace cleanup, V2

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-04-09.12:04:19.234>
created_at = <Date 2015-12-02.16:40:47.257>
labels = ['type-feature', 'library']
title = 'Add support for CAN_RAW_JOIN_FILTERS'
updated_at = <Date 2020-04-09.12:04:19.234>
user = 'https://github.com/rumpelsepp'

bugs.python.org fields:

activity = <Date 2020-04-09.12:04:19.234>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-09.12:04:19.234>
closer = 'pablogsal'
components = ['Library (Lib)']
creation = <Date 2015-12-02.16:40:47.257>
creator = 'rumpelsepp'
dependencies = []
files = ['41210', '41211', '41218']
hgrepos = []
issue_num = 25780
keywords = ['patch']
message_count = 10.0
messages = ['255723', '255724', '255782', '255783', '255784', '255786', '255787', '255789', '255790', '366043']
nosy_count = 5.0
nosy_names = ['r.david.murray', 'martin.panter', 'rumpelsepp', 'ZackerySpytz', 'pablogsal']
pr_nums = ['19190']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25780'
versions = ['Python 3.6']

[rumpelsepp]

Here is a patch, which adds support for CAN_RAW_JOIN_FILTERS which is available since linux 4.1 1. My patch fixes trailing whitespace issues as well. Since I have a newer version of autotools, running "autoreconf" generates a lot of changes, so I left that out for the time being.

[rumpelsepp]

in case you don't like whitespace cleanups, here is the patch with "git diff --ignore-space-changes".

[vadmium]

Not sure what the general policy is, but IMO it is better to leave offensive white space as it is to avoid flooding the file history and diffs, unless you are editing nearby lines.

I will leave some review comments for the documentation.

[bitdancer]

In this particular case, whether we want to do that to config.ac is a separate question and should be addressed in a separate issue.

[rumpelsepp]

Because is the first time I work with this bugtracking system on python.org, how can I update my patch? :) Just upload a new one?

[bitdancer]

Yes. The review system will automatically include the new patch, regardless of its name (it looks at the content).

[rumpelsepp]

Thanks! Here is an update.

[vadmium]

The other thing for new features is test cases. I don’t know if there are any existing CAN socket tests (in fact I don’t know anything about CAN sockets). Is it possible to make a test for this? Even if it just ensures that the setting can be applied when supported. Though I guess if this is too hard it may not be worth it.

[rumpelsepp]

Hmm. I just adapted this feature request from bpo-22631 for the new constant and I verified that my patch actually works. I could try to provide a test, but then I would have to open Pandora's box as I am not a CPython developer at all. :/

[pablogsal]

New changeset 97e0de0 by Zackery Spytz in branch 'master':
bpo-25780: Expose CAN_RAW_JOIN_FILTERS in the socket module (GH-19190)
97e0de0