Update the list of magic numbers in launcher

[serhiy-storchaka]

BPO	26073
Nosy	@brettcannon, @pfmoore, @ncoghlan, @tjguk, @ericsnowcurrently, @zware, @serhiy-storchaka, @zooba
Files	launcher_magic_numbers.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2016-01-16.21:50:02.955>
created_at = <Date 2016-01-10.07:49:53.691>
labels = ['type-bug', 'OS-windows']
title = 'Update the list of magic numbers in launcher'
updated_at = <Date 2016-05-16.16:35:49.709>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-05-16.16:35:49.709>
actor = 'python-dev'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2016-01-16.21:50:02.955>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2016-01-10.07:49:53.691>
creator = 'serhiy.storchaka'
dependencies = []
files = ['41564']
hgrepos = []
issue_num = 26073
keywords = ['patch']
message_count = 5.0
messages = ['257896', '258421', '258422', '265447', '265710']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'paul.moore', 'ncoghlan', 'tim.golden', 'python-dev', 'eric.snow', 'zach.ware', 'serhiy.storchaka', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26073'
versions = ['Python 3.5', 'Python 3.6']

[serhiy-storchaka]

There is a list of magic numbers in PC/launcher.c for mapping magic number to Python version. But it ends on 3.3 (and even only on 3.3a0). Proposed patch updates the list (by values taken from Lib/importlib/_bootstrap_external.py).

[python-dev]

New changeset 1a2cfa52f749 by Steve Dower in branch '3.5':
Issue bpo-26073: Update the list of magic numbers in launcher
https://hg.python.org/cpython/rev/1a2cfa52f749

New changeset cf868f77b400 by Steve Dower in branch 'default':
Issue bpo-26073: Update the list of magic numbers in launcher
https://hg.python.org/cpython/rev/cf868f77b400

[zooba]

Thanks!

[serhiy-storchaka]

Steve, could you please add a comment in Lib/importlib/_bootstrap_external.py about the need to update PC/launcher.c?

[python-dev]

New changeset d921932fe02f by Steve Dower in branch '3.5':
Issue bpo-26073: Updates magic number comment in _bootstrap_external.py and changes numbers in launcher.py to decimal to match official table.
https://hg.python.org/cpython/rev/d921932fe02f

New changeset 0fe913de4702 by Steve Dower in branch 'default':
Issue bpo-26073: Updates magic number comment in _bootstrap_external.py and changes numbers in launcher.py to decimal to match official table.
https://hg.python.org/cpython/rev/0fe913de4702