Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing header on android for the ossaudiodev module #71041

Closed
xdegaye mannequin opened this issue Apr 26, 2016 · 5 comments
Closed

missing header on android for the ossaudiodev module #71041

xdegaye mannequin opened this issue Apr 26, 2016 · 5 comments
Assignees
Labels
build The build process and cross-build

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Apr 26, 2016

BPO 26854
Nosy @skrah, @xdegaye, @moreati, @yan12125
Files
  • ossaudiodev.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/skrah'
    closed_at = <Date 2016-04-26.14:52:12.639>
    created_at = <Date 2016-04-26.13:07:45.688>
    labels = ['build']
    title = 'missing header on android for the ossaudiodev module'
    updated_at = <Date 2016-04-26.17:55:40.511>
    user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2016-04-26.17:55:40.511>
    actor = 'skrah'
    assignee = 'skrah'
    closed = True
    closed_date = <Date 2016-04-26.14:52:12.639>
    closer = 'skrah'
    components = ['Cross-Build']
    creation = <Date 2016-04-26.13:07:45.688>
    creator = 'xdegaye'
    dependencies = []
    files = ['42605']
    hgrepos = []
    issue_num = 26854
    keywords = ['patch']
    message_count = 5.0
    messages = ['264276', '264298', '264299', '264316', '264321']
    nosy_count = 5.0
    nosy_names = ['skrah', 'xdegaye', 'python-dev', 'Alex.Willmer', 'yan12125']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue26854'
    versions = ['Python 3.6']

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Apr 26, 2016

    On linux /usr/include/sys/soundcard.h includes /usr/include/linux/soundcard.h while on android (also a linux) there is only /usr/include/linux/soundcard.h

    Patch attached.

    @xdegaye xdegaye mannequin added build The build process and cross-build labels Apr 26, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 26, 2016

    New changeset d943e6f7c9f3 by Stefan Krah in branch 'default':
    Issue bpo-26854: Android has a different include path for soundcard.h.
    https://hg.python.org/cpython/rev/d943e6f7c9f3

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Apr 26, 2016

    Thanks!

    @skrah skrah mannequin closed this as completed Apr 26, 2016
    @skrah skrah mannequin self-assigned this Apr 26, 2016
    @yan12125
    Copy link
    Mannequin

    yan12125 mannequin commented Apr 26, 2016

    Maybe checking sys/soundcard.h and linux/soundcard.h in configure.ac is better?

    [1] https://github.com/yan12125/python3-android/blob/cpython-hg/mk/python/soundcard-h-path.patch

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Apr 26, 2016

    Since Android is the only known system with an odd include path, I
    prefer the short patch. In general, let's try to keep patches as
    short as possible (which Xavier is already doing).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants