Allow non-ascii chars in IDLE NEWS.txt (for contributor names)

[terryjreedy]

BPO	27365
Nosy	@terryjreedy, @larryhastings, @benjaminp, @ned-deily, @serhiy-storchaka
Files	idle-news-27.diff idle-news-36.diff idle-news-35.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-06-25.21:05:01.007>
created_at = <Date 2016-06-22.03:04:05.112>
labels = ['expert-IDLE', 'type-bug', 'release-blocker']
title = 'Allow non-ascii chars in IDLE NEWS.txt (for contributor names)'
updated_at = <Date 2019-03-21.18:17:57.493>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2019-03-21.18:17:57.493>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-06-25.21:05:01.007>
closer = 'larry'
components = ['IDLE']
creation = <Date 2016-06-22.03:04:05.112>
creator = 'terry.reedy'
dependencies = []
files = ['43503', '43504', '43505']
hgrepos = []
issue_num = 27365
keywords = ['patch']
message_count = 22.0
messages = ['269042', '269045', '269048', '269051', '269052', '269053', '269054', '269056', '269057', '269059', '269060', '269061', '269065', '269066', '269067', '269069', '269076', '269084', '269088', '269147', '269258', '269342']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'larry', 'benjamin.peterson', 'ned.deily', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27365'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[terryjreedy]

A month ago, for 3.5 and 3.6, I added a test file by Westley Martínez (note accent on i) and then his name into Misc/NEWS and idlelib/NEWS.txt. As a result, the latter will not display when the button on About IDLE is clicked. Instead, a UnicodeDecodeError is sent to stderr. I will add a test for the About box.

[terryjreedy]

Larry, there is a slight reversion in 3.5.2rc that I think should be fixed: idlelib/NEWS.txt will not display from About IDLE dialog because it had a couple of non-ascii chars. idle_news-35.diff has the full patch. A minimal fix for 3.5.2 final would consist of changing 'ascii' to 'utf-8' in idlelib/aboutDialog.py and the recoding the 2 characters in NEWS. Testing changes in the other 2 files could wait.

Since I don't know how you want to do this now, I have not pushed anything yet.

[python-dev]

New changeset 45d4cea97b04 by Benjamin Peterson in branch '2.7':
fix idle about dialog bpo-27365
https://hg.python.org/cpython/rev/45d4cea97b04

[larryhastings]

If the diff is literally changing two lines, I'll accept it. Guido relaxed the rules for IDLE changes. If it breaks something it's on *your* head ;-)

Please just check it in normally. Either I'm going to use hg to cherry-pick the changes for 3.5.2 final, or I'm going to have to apply patches manually anyway. Either way an hg checkin is fine.

Please check in this minimal change *as a separate checkin* from the larger changes, if you're committing the other changes any time soon.

[terryjreedy]

I should mention that I have separate 3.5 and 3.6 patches because I know that the merge will not work.

[terryjreedy]

I was wondering if splitting the patch would be better. Shelve makes it easy.

[python-dev]

New changeset 783dfd77e4c1 by Terry Jan Reedy in branch '3.5':
Issue bpo-27365: Allow non-ascii in idlelib/NEWS.txt - minimal part for 3.5.2.
https://hg.python.org/cpython/rev/783dfd77e4c1

New changeset b8926908d2a0 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: Merge minimal part.
https://hg.python.org/cpython/rev/b8926908d2a0

[terryjreedy]

783dfd77e4c1 is the one to pick for 3.5, then null merge if you merge to 3.6.

[python-dev]

New changeset d5ee1e5c1ac0 by Terry Jan Reedy in branch '3.5':
Issue bpo-27365: Allow non-ascii in idlelib/NEWS.txt, for contributor names.
https://hg.python.org/cpython/rev/d5ee1e5c1ac0

New changeset e7ecad98a785 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: temporary rename
https://hg.python.org/cpython/rev/e7ecad98a785

New changeset a4aa45859b5c by Terry Jan Reedy in branch 'default':
Issue bpo-27365: partial merge
https://hg.python.org/cpython/rev/a4aa45859b5c

[python-dev]

New changeset 54dde0cb10f9 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: revert temporary rename
https://hg.python.org/cpython/rev/54dde0cb10f9

New changeset be0dec826982 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: add chunk
https://hg.python.org/cpython/rev/be0dec826982

[python-dev]

New changeset 3a122d0e4187 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: add chunk
https://hg.python.org/cpython/rev/3a122d0e4187

[python-dev]

New changeset 49323bb44229 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: revert temporary rename
https://hg.python.org/cpython/rev/49323bb44229

[terryjreedy]

Because of the case conflict I did not notice soon enough, the rest of the patch and merge did not go well and I got this

test test_idle crashed -- Traceback (most recent call last):
  File "F:\Python\dev\36\lib\test\libregrtest\runtest.py", line 180, in runtest_inner
    test_runner()
  File "F:\Python\dev\36\lib\test\libregrtest\runtest.py", line 178, in test_runner
    raise Exception("errors while loading tests")
Exception: errors while loading tests

I suspect it is a problem with textView/textview, so I will temporarily disable test files to find the culprit.

[python-dev]

New changeset 33769ce40b47 by Terry Jan Reedy in branch 'default':
Issue bpo-27365: Finish merge so tests pass.
https://hg.python.org/cpython/rev/33769ce40b47

[terryjreedy]

Suspicion wrong. idle_test and hand tests pass.

Larry, I am done with this. I left it open until you are also.

[serhiy-storchaka]

Is this dance with renaming forever?

[terryjreedy]

No, it ends with the last 3.5 maintenance release in about 6 months. When I did it right, as in bpo-27245, which was otherwise a clean single file merge, there was no problem and it took at most an extra 30 seconds. I know what I did wrong this time, starting with not writing down the steps needed, and in which order, for a much more complicated merge.

[larryhastings]

You speak confidently, for a guy who hasn't seen any sort of schedule from the 3.5 RM. :-O

After 3.6 comes out, I expect 3.5 to get one more "bug fix" release. And *then* it will transition to "security fixes only" mode. Six months is the absolute minimum, and I'd expect it to be longer than that.

[terryjreedy]

As a practical matter, I have no plans to backport except in exceptional cases. If the regression had only affected 3.6, I would have left 2.7 and 3.5 alone.

[python-dev]

New changeset cbc6407fa393 by Terry Jan Reedy in branch '2.7':
Issue bpo-27365: Add blank lines. to 2.7 test_editmenu
https://hg.python.org/cpython/rev/cbc6407fa393

[larryhastings]

If this is fixed, and resolved, why is it still open? Closing.

[python-dev]

New changeset 30e563e2702e by Terry Jan Reedy in branch '3.5':
Issue bpo-27365: Allow non-ascii in idlelib/NEWS.txt - minimal part for 3.5.2.
https://hg.python.org/cpython/rev/30e563e2702e