-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Add pyd icon for 3.6 #71943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I did some working and did a halfed one for pyd's it basically combines it icon from python.exe with the DLL "gears" for windows DLL's beig under that. Hopefully it will work. (Anyone could use this as a base file and restyle it or whatever if they want. At least I tried. (note: the file would have to go under the PC directory as well. Hopefully something from the python installer can associate them with pyd files so that way people can distinquish them from any other file type (like pdbs,lib,w/e with no icon(s)). |
It's certainly very easy to add an icon for pyd files. The tricky part is getting an icon we can redistribute - fairly sure one derived from a Windows icon is not redistributable. Let me see if I can get one of the designers at work to put something together. Maybe it's time for a whole new set :) |
Please keep a rocket in the upper left-hand corner for the launcher icon. It distinguishes the launcher from other "Python" apps when modifying the shell's file association, since the shell doesn't show the command-line template to the user. Of course, it would also help if the description in py.exe were changed to "Python Launcher" instead of just "Python". |
Can't promise there'll be a rocket, but the launcher icon will certainly be different from the source file icon. |
Got an impressively quick response from one of our willing designers, who has proposed the attached icons. In order, they would be:
Any suggestions or comments? I personally think they look great. |
Should pyw.exe get its own icon? Otherwise these look good to me; they're less busy than the existing icons, which is probably for the best. Is there a potential licensing problem with borrowing the look of the Win+R dialog icon, or is this fair use? |
It's probably not worth doing pyw.exe - even distinguishing between python.exe and pythonw.exe is only possible because we came up with that icon before the alternative one for the launcher. The style just imitates the icon in the Run dialog (the "feeling of speed"), it's not the same image. Only the Python logo is a concern, but we're allowed to use that one :) |
New changeset 29815771f2ac by Steve Dower in branch 'default': |
The new beautiful icons have been checked in! |
New changeset 386aa9738c6b by Steve Dower in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: