-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Avoid possible crash in pysqlite_connection_create_collation #72084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
When supplied a custom string with upper returning a non-string, pysqlite_connection_create_collation will fail assertion and crash. Serhiy, I think we can use the same way in set_isolation_level to avoid this. |
New changeset c739660489c1 by Serhiy Storchaka in branch '3.5': New changeset c2eb90422aec by Serhiy Storchaka in branch '3.6': New changeset 9fc2b6dba9c2 by Serhiy Storchaka in branch 'default': |
New changeset 1aae9b7ff321 by Serhiy Storchaka in branch '2.7': |
LGTM. Thank you for your patch. |
The test in 2.7 (1aae9b7ff321) seems to cause a Windows 8.1 buildbot to hang in test_sqlite. I deduced this because there is no mention of "test_sqlite" in the test log output, compared to a previous successful test log. http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Non-Debug%202.7/builds/474 |
New changeset 38e954a2a37e by Serhiy Storchaka in branch '2.7': |
Thanks Martin! |
Misc/NEWS
so that it is managed by towncrier #552Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: