Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled libffi #72166

Closed
zware opened this issue Sep 6, 2016 · 4 comments
Closed

Remove bundled libffi #72166

zware opened this issue Sep 6, 2016 · 4 comments
Labels
3.7 build expert-ctypes type-feature

Comments

@zware
Copy link
Member

@zware zware commented Sep 6, 2016

BPO 27979
Nosy @zware, @yan12125
PRs
  • #552
  • Dependencies
  • bpo-27976: Deprecate building with bundled copy of libffi on non-Darwin POSIX platforms
  • Files
  • remove_bundled_libffi.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-09-17.06:37:25.664>
    created_at = <Date 2016-09-06.18:53:39.053>
    labels = ['ctypes', 'type-feature', '3.7', 'build']
    title = 'Remove bundled libffi'
    updated_at = <Date 2017-03-31.16:36:21.242>
    user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:21.242>
    actor = 'dstufft'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-09-17.06:37:25.664>
    closer = 'python-dev'
    components = ['Build', 'ctypes']
    creation = <Date 2016-09-06.18:53:39.053>
    creator = 'zach.ware'
    dependencies = ['27976']
    files = ['44400']
    hgrepos = []
    issue_num = 27979
    keywords = ['patch']
    message_count = 4.0
    messages = ['274600', '274927', '276773', '277298']
    nosy_count = 3.0
    nosy_names = ['python-dev', 'zach.ware', 'yan12125']
    pr_nums = ['552']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue27979'
    versions = ['Python 3.7']

    @zware
    Copy link
    Member Author

    @zware zware commented Sep 6, 2016

    The attached patch allows the bundled libffi used in non-Darwin POSIX builds (Modules/_ctypes/libffi, along with Modules/_ctypes/libffi.diff) to be removed. It depends on the patch in bpo-27976, and does not affect OSX or Windows.

    @zware zware added 3.7 build expert-ctypes type-feature labels Sep 6, 2016
    @zware
    Copy link
    Member Author

    @zware zware commented Sep 8, 2016

    The patch will need to be updated to just completely remove the --with(out)-system-ffi check everywhere but OSX. It will also need to make some changes after the latest patch in bpo-27976.

    @python-dev
    Copy link
    Mannequin

    @python-dev python-dev mannequin commented Sep 17, 2016

    New changeset d4981c76a8b9 by Zachary Ware in branch 'default':
    Closes bpo-27979: Remove bundled copy of libffi
    https://hg.python.org/cpython/rev/d4981c76a8b9

    @python-dev python-dev mannequin closed this as completed Sep 17, 2016
    @yan12125
    Copy link
    Mannequin

    @yan12125 yan12125 mannequin commented Sep 23, 2016

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 build expert-ctypes type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant