Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 525 asynchronous generators implementation #72190

Closed
1st1 opened this issue Sep 7, 2016 · 7 comments
Closed

PEP 525 asynchronous generators implementation #72190

1st1 opened this issue Sep 7, 2016 · 7 comments
Assignees
Labels
interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Sep 7, 2016

BPO 28003
Nosy @vstinner, @ambv, @vadmium, @1st1
Files
  • asyncgen_1.patch
  • async_gen.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
    closed_at = <Date 2016-09-09.05:02:50.005>
    created_at = <Date 2016-09-07.17:29:34.352>
    labels = ['interpreter-core', 'type-feature']
    title = 'PEP 525 asynchronous generators implementation'
    updated_at = <Date 2016-11-09.00:46:48.548>
    user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2016-11-09.00:46:48.548>
    actor = 'python-dev'
    assignee = 'yselivanov'
    closed = True
    closed_date = <Date 2016-09-09.05:02:50.005>
    closer = 'yselivanov'
    components = ['Interpreter Core']
    creation = <Date 2016-09-07.17:29:34.352>
    creator = 'yselivanov'
    dependencies = []
    files = ['44443', '44484']
    hgrepos = []
    issue_num = 28003
    keywords = ['patch']
    message_count = 7.0
    messages = ['274845', '275257', '275258', '275270', '275272', '275273', '280365']
    nosy_count = 5.0
    nosy_names = ['vstinner', 'lukasz.langa', 'python-dev', 'martin.panter', 'yselivanov']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28003'
    versions = ['Python 3.6']

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 7, 2016

    The PEP has been accepted, let's review the reference implementation and get it committed.

    @1st1 1st1 self-assigned this Sep 7, 2016
    @1st1 1st1 added interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Sep 7, 2016
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 9, 2016

    New changeset 5259588983ca by Yury Selivanov in branch 'default':
    Issue bpo-28003: Implement PEP-525 -- Asynchronous Generators.
    https://hg.python.org/cpython/rev/5259588983ca

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 9, 2016

    Committed. Thanks Victor for the review!

    @1st1 1st1 closed this as completed Sep 9, 2016
    @vadmium
    Copy link
    Member

    vadmium commented Sep 9, 2016

    I am getting a new GCC warning:

    ./Python/sysmodule.c:1425:28: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
    {"set_asyncgen_hooks", sys_set_asyncgen_hooks,
    ^~~~~~~~~~~~~~~~~~~~~~
    ./Python/sysmodule.c:1425:28: note: (near initialization for ‘sys_methods[34].ml_meth’)

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 9, 2016

    New changeset 910e293663cb by Yury Selivanov in branch 'default':
    Issue bpo-28003: Fix a compiler warning
    https://hg.python.org/cpython/rev/910e293663cb

    @1st1
    Copy link
    Member Author

    1st1 commented Sep 9, 2016

    Thanks, Martin, it should be fixed now.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 9, 2016

    New changeset 9f32ef6b210b by Yury Selivanov in branch '3.6':
    Issue bpo-28003: Make WrappedVal, ASend and AThrow GC types
    https://hg.python.org/cpython/rev/9f32ef6b210b

    New changeset 6f51b495656c by Yury Selivanov in branch 'default':
    Merge 3.6 (issue bpo-28003)
    https://hg.python.org/cpython/rev/6f51b495656c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core Interpreter core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants