test_traceback is broken by new CALL_FUNCTION* opcodes

[vstinner]

BPO	28050
Nosy	@vstinner, @serhiy-storchaka, @Vgr255, @serprex

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-05.17:07:10.655>
created_at = <Date 2016-09-09.19:11:31.462>
labels = []
title = 'test_traceback is broken by new CALL_FUNCTION* opcodes'
updated_at = <Date 2016-12-05.17:27:41.587>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2016-12-05.17:27:41.587>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-05.17:07:10.655>
closer = 'vstinner'
components = []
creation = <Date 2016-09-09.19:11:31.462>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 28050
keywords = []
message_count = 6.0
messages = ['275396', '275403', '275453', '282438', '282440', '282441']
nosy_count = 5.0
nosy_names = ['vstinner', 'python-dev', 'serhiy.storchaka', 'abarry', 'Demur Rumed']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28050'
versions = ['Python 3.6']

[vstinner]

I skipped the failing tests just to be able to push my FASTCALL changes before Python 3.6 feature freeze.

I opened this issue to not forget to fix it.

[python-dev]

New changeset a77756e480c2 by Victor Stinner in branch 'default':
Rework CALL_FUNCTION* opcodes
https://hg.python.org/cpython/rev/a77756e480c2

[vstinner]

Serhiy proposed a fix in the issue bpo-27213 (starting at callfunc-10.patch).

[vstinner]

Oh, this issue was already fixed, thanks Serhiy :-)

changeset: 103659:51b635e81958
user: Serhiy Storchaka <storchaka@gmail.com>
date: Mon Sep 12 00:52:40 2016 +0300
files: Include/abstract.h Lib/dis.py Lib/test/test_extcall.py Lib/test/test_traceback.py Objects/abstract.c Objects/methodobject.c Python/ceval.c Python/compile.c Python/importlib.h Python/imp
description:
Issue bpo-27213: Fixed different issues with reworked CALL_FUNCTION* opcodes.

• BUILD_TUPLE_UNPACK and BUILD_MAP_UNPACK_WITH_CALL no longer generated with
  single tuple or dict.
• Restored more informative error messages for incorrect var-positional and
  var-keyword arguments.
• Removed code duplications in _PyEval_EvalCodeWithName().
• Removed redundant runtime checks and parameters in _PyStack_AsDict().
• Added a workaround and enabled previously disabled test in test_traceback.
• Removed dead code from the dis module.

[serhiy-storchaka]

It is rather worked around.

[vstinner]

Serhiy Storchaka added the comment:

It is rather worked around.

The test pass, the change looks good to me. I don't think that it's
still worth it to keep the issue open ;-)