Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyDict_SetDefault doesn't combine split table when needed #72769

Closed
zhangyangyu opened this issue Nov 1, 2016 · 6 comments
Closed

PyDict_SetDefault doesn't combine split table when needed #72769

zhangyangyu opened this issue Nov 1, 2016 · 6 comments
Assignees
Labels
3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error

Comments

@zhangyangyu
Copy link
Member

BPO 28583
Nosy @ned-deily, @methane, @serhiy-storchaka, @zhangyangyu
PRs
  • [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
  • Files
  • PyDict_SetDefault.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/methane'
    closed_at = <Date 2016-11-02.09:47:57.360>
    created_at = <Date 2016-11-01.18:33:44.585>
    labels = ['interpreter-core', 'type-bug', '3.7', 'release-blocker']
    title = "PyDict_SetDefault doesn't combine split table when needed"
    updated_at = <Date 2017-03-31.16:36:10.509>
    user = 'https://github.com/zhangyangyu'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:10.509>
    actor = 'dstufft'
    assignee = 'methane'
    closed = True
    closed_date = <Date 2016-11-02.09:47:57.360>
    closer = 'methane'
    components = ['Interpreter Core']
    creation = <Date 2016-11-01.18:33:44.585>
    creator = 'xiang.zhang'
    dependencies = []
    files = ['45308']
    hgrepos = []
    issue_num = 28583
    keywords = ['patch']
    message_count = 6.0
    messages = ['279889', '279900', '279902', '279911', '279914', '279915']
    nosy_count = 5.0
    nosy_names = ['ned.deily', 'methane', 'python-dev', 'serhiy.storchaka', 'xiang.zhang']
    pr_nums = ['552']
    priority = 'release blocker'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue28583'
    versions = ['Python 3.6', 'Python 3.7']

    @zhangyangyu
    Copy link
    Member Author

    PyDict_SetDefault doesn't combine split table when needed. This could lead to loss of order or crash. This is a follow up of bpo-28199.

    @zhangyangyu zhangyangyu added 3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Nov 1, 2016
    @zhangyangyu
    Copy link
    Member Author

    Here is a patch.

    @methane
    Copy link
    Member

    methane commented Nov 2, 2016

    LGTM

    @serhiy-storchaka
    Copy link
    Member

    Besides the patch is a little hard to understanding due to changes that are not directly related to the issue, it LGTM.

    @methane
    Copy link
    Member

    methane commented Nov 2, 2016

    I'll commit.

    @methane methane self-assigned this Nov 2, 2016
    @1762cc99-3127-4a62-9baf-30c3d0f51ef7
    Copy link
    Mannequin

    python-dev mannequin commented Nov 2, 2016

    New changeset 4e9c7704f373 by INADA Naoki in branch '3.6':
    Issue bpo-28583: PyDict_SetDefault didn't combine split table when needed.
    https://hg.python.org/cpython/rev/4e9c7704f373

    New changeset a6a79053aec4 by INADA Naoki in branch 'default':
    Issue bpo-28583: PyDict_SetDefault didn't combine split table when needed.
    https://hg.python.org/cpython/rev/a6a79053aec4

    @methane methane closed this as completed Nov 2, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants