Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio.isfuture() should support Mocks #72820

Closed
1st1 opened this issue Nov 7, 2016 · 2 comments
Closed

asyncio.isfuture() should support Mocks #72820

1st1 opened this issue Nov 7, 2016 · 2 comments
Assignees
Labels
3.7 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@1st1
Copy link
Member

1st1 commented Nov 7, 2016

BPO 28634
Nosy @gvanrossum, @1st1

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/1st1'
closed_at = <Date 2016-11-07.21:00:31.696>
created_at = <Date 2016-11-07.21:00:19.493>
labels = ['type-bug', '3.7', 'expert-asyncio']
title = 'asyncio.isfuture() should support Mocks'
updated_at = <Date 2016-11-07.21:08:05.604>
user = 'https://github.com/1st1'

bugs.python.org fields:

activity = <Date 2016-11-07.21:08:05.604>
actor = 'python-dev'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2016-11-07.21:00:31.696>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2016-11-07.21:00:19.493>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 28634
keywords = []
message_count = 2.0
messages = ['280241', '280242']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'python-dev', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28634'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

@1st1
Copy link
Member Author

1st1 commented Nov 7, 2016

In short:

isfuture(unittest.mock.Mock()) should be False
isfuture(unittest.mock.Mock(Future)) should be True

This issue is a proxy for python/asyncio#455

@1st1 1st1 added the 3.7 only security fixes label Nov 7, 2016
@1st1 1st1 self-assigned this Nov 7, 2016
@1st1 1st1 added topic-asyncio type-bug An unexpected behavior, bug, or error labels Nov 7, 2016
@1st1 1st1 closed this as completed Nov 7, 2016
@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 7, 2016

New changeset 0669dcf1eb36 by Yury Selivanov in branch '3.5':
Issue bpo-28634: Fix asyncio.isfuture() to support mocks
https://hg.python.org/cpython/rev/0669dcf1eb36

New changeset a02915e4c165 by Yury Selivanov in branch '3.6':
Merge 3.5 (issue bpo-28634)
https://hg.python.org/cpython/rev/a02915e4c165

New changeset 44c1ec7689e5 by Yury Selivanov in branch 'default':
Merge 3.6 (issue bpo-28634)
https://hg.python.org/cpython/rev/44c1ec7689e5

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.7 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant