-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Make test.support.rmtree() able to remove non-writable directories #72852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some tests create directories with disabled writing or even reading and listing. If them fail test.support.rmtree() can't remove such directories. This cause failures in other tests. Proposed patch makes test.support.rmtree() able to remove such directories. If some operation fails it try to change the mode of corresponding directory and repeat the try. |
The patch looks good to me. This can be applied, and tests are running fine with the patch. |
New changeset 63820871014d by Serhiy Storchaka in branch '2.7': New changeset c92f9be77b9b by Serhiy Storchaka in branch '3.5': New changeset efe2993b20e2 by Serhiy Storchaka in branch '3.6': New changeset 3a1e75ecc17d by Serhiy Storchaka in branch 'default': |
Thanks Kushal. |
New changeset b51607ea54c5 by Serhiy Storchaka in branch '2.7': New changeset 9e23b8996584 by Serhiy Storchaka in branch '3.5': New changeset 82ca763882f5 by Serhiy Storchaka in branch '3.6': New changeset 593ec9658f4b by Serhiy Storchaka in branch 'default': |
New changeset da1880183693 by Serhiy Storchaka in branch 'default': |
New changeset 573fd9607c75 by Serhiy Storchaka in branch '3.5': New changeset 01f867e9cd34 by Serhiy Storchaka in branch '2.7': New changeset b9e1a51a2d19 by Serhiy Storchaka in branch '3.6': |
New changeset dd378356c77c by Martin Panter in branch '2.7': |
Misc/NEWS
so that it is managed by towncrier #552Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: