update SQLite libraries for Windows and macOS installers

[BigStone]

BPO	28791
Nosy	@rhettinger, @pfmoore, @ronaldoussoren, @vstinner, @tjguk, @benjaminp, @ned-deily, @berkerpeksag, @zware, @zooba, @Mariatta
PRs	bpo-28791: Update OS X installer to use SQLite 3.21.0. #4245 bpo-28791: Update Windows installer to use SQLite 3.21.0. #4246 [3.6] bpo-28791: Update macOS installer to use SQLite 3.21.0. (#4245) #4711 [3.6] bpo-28791: Update Windows builds to use SQLite 3.21.0. (GH-4246). #4717

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-22.21:12:48.462>
created_at = <Date 2016-11-24.20:05:28.854>
labels = ['OS-mac', '3.7', 'expert-installation', 'OS-windows']
title = 'update SQLite libraries for Windows and macOS installers'
updated_at = <Date 2018-12-22.21:13:16.626>
user = 'https://bugs.python.org/BigStone'

bugs.python.org fields:

activity = <Date 2018-12-22.21:13:16.626>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-22.21:12:48.462>
closer = 'zach.ware'
components = ['Installation', 'macOS', 'Windows']
creation = <Date 2016-11-24.20:05:28.854>
creator = 'Big Stone'
dependencies = []
files = []
hgrepos = []
issue_num = 28791
keywords = ['patch']
message_count = 24.0
messages = ['281650', '281920', '282035', '282093', '282097', '288662', '288675', '288728', '301736', '305369', '305686', '305709', '305745', '305795', '305931', '307613', '307617', '307618', '307619', '307625', '307637', '307638', '308621', '332370']
nosy_count = 12.0
nosy_names = ['rhettinger', 'paul.moore', 'ronaldoussoren', 'vstinner', 'tim.golden', 'benjamin.peterson', 'ned.deily', 'berker.peksag', 'zach.ware', 'steve.dower', 'Big Stone', 'Mariatta']
pr_nums = ['4245', '4246', '4711', '4717']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28791'
versions = ['Python 3.6', 'Python 3.7']

[BigStone]

I fear it's too late for Python-3.6, but sqlite-3.15.1 fixes an old annoying bug (hidden since 3.8.0), and arriving tomorrow (nov.24th) sqlite-3.15.2 should be the well ".2" stabilized version of recent 3.15 improvements towards SQL standard (support for row values)

If there is no special bugs left in Python-3.6.0b4 and everybody is happy, I would suggest you upgrade from sqlite-3.14.2 to sqlite-3.15.2

[BigStone]

too late for sqlite-0.15.2 in Python-3.6.0rc ?

[ned-deily]

Yes, we're not going to change library versions for the 3.6.0 installers at this point. Upgrade for 3.7.0 is fine and possibly for a 3.6.x maintenance release if warranted. I suggest holding off on any patches until we're closer to those releases as there may be subsequent SQLite updates.

[BigStone]

I understand the decision. Yet it always baffles me that a version correcting known bugs is not included at beta stage.

[zooba]

I don't think we have anyone actively tracking SQLite right now, like we do for OpenSSL.

All it really needs is someone to prepare and test the patch during the beta period, and to be available in case more fixes are required. At this stage, we're in the RC period, so there really needs to be a recall-level issue to justify a change, and even then we'd prefer a maintenance update rather than a feature update (e.g. 3.14.3 vs. 3.15.x - if it's not a recall-level issue for SQLite, then it's hard to call it a recall-level issue for Python).

[Mariatta]

Is this something we want to include for the upcoming 3.6.1 release?
The latest sqlite version is 3.17.0.

[BigStone]

python-3.7 should include the latest stable sqlite, at the time of last alpha.

[Mariatta]

Thanks, Big Stone. Setting the version to 3.7.

[zware]

In an effort to not forget about this, I'm setting it to deferred blocker.

[berkerpeksag]

In an effort to not forget about this, I'm setting it to deferred blocker.

Should we mark bpo-30952 'deferred blocker' too?

[vstinner]

Oh wow, I didn't even know that Python included a copy of SQLite for Windows and macOS installers! I added it to my list of "embedded libraries" :-)
http://haypo-notes.readthedocs.io/cpython.html#embedded-libraries

[Mariatta]

New changeset 31af650 by Mariatta in branch 'master':
bpo-28791: Update Windows builds to use SQLite 3.21.0. (GH-4246)
31af650

[vstinner]

sqlite-3.15.1 fixes an old annoying bug (hidden since 3.8.0)

Since the bug seems to be important, maybe it's worth it to backport the commit upgrading SQLite to Python 2.7 and 3.6?

[zware]

I'd say that's up to Ned and Benjamin. It's a very simple backport at this point.

[rhettinger]

+1 for backporting.

[ned-deily]

New changeset ca7562a by Ned Deily (Mariatta) in branch 'master':
bpo-28791: Update macOS installer to use SQLite 3.21.0. (bpo-4245)
ca7562a

[ned-deily]

New changeset a72e7bf by Ned Deily in branch '3.6':
[3.6] bpo-28791: Update macOS installer to use SQLite 3.21.0. (bpo-4245) (bpo-4711)
a72e7bf

[ned-deily]

I've updated the macOS installer for 3.7.0 and for 3.6.4. I'll leave this open for possible updating the Windows installer for 3.6.x (OK by me) and for possible updates for 2.7.x.

[ned-deily]

Should we mark bpo-30952 'deferred blocker' too?

No, that's a different matter. AFAICT, there is no standard option for that.

[Mariatta]

Tried to get miss-islington to backport Windows installer change to 3.6, did not work.

I'll work on the backport PR.

[Mariatta]

New changeset e2ba552 by Mariatta in branch '3.6':
bpo-28791: Update Windows builds to use SQLite 3.21.0. (GH-4246). (GH-4717)
e2ba552

[Mariatta]

Backport to 3.6 is done. But I personally won't be bothering with 2.7 :)

[ned-deily]

Looks like unless Benjamin would like 2.7.x updated, this can now be closed.

[zware]

Since we have a more recent "update SQLite" issue in bpo-35360, I'm going to go ahead and close this one.