Make enum.py pep8 compliant

[realitix]

BPO	29103
Nosy	@warsaw, @rhettinger, @bitdancer, @ethanfurman, @realitix
Files	enum_format.patch: Patch to fix enum.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-30.05:19:15.680>
created_at = <Date 2016-12-29.07:37:30.605>
labels = ['3.7', 'type-feature', 'library']
title = 'Make enum.py pep8 compliant'
updated_at = <Date 2016-12-30.18:22:40.596>
user = 'https://github.com/realitix'

bugs.python.org fields:

activity = <Date 2016-12-30.18:22:40.596>
actor = 'ethan.furman'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-30.05:19:15.680>
closer = 'rhettinger'
components = ['Library (Lib)']
creation = <Date 2016-12-29.07:37:30.605>
creator = 'realitix'
dependencies = []
files = ['46071']
hgrepos = []
issue_num = 29103
keywords = ['patch']
message_count = 6.0
messages = ['284234', '284267', '284308', '284317', '284319', '284337']
nosy_count = 7.0
nosy_names = ['barry', 'rhettinger', 'r.david.murray', 'eli.bendersky', 'ethan.furman', 'python-dev', 'realitix']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29103'
versions = ['Python 3.7']

[realitix]

Hello,
This is my first patch on CPython, so please tell me if I do something wrong.

When executing flake8 on Lib/enum.py, there are lot of warning. This patch remove all these warnings.

[bitdancer]

In general we do not accept PEP-8 patches; it is code churn with insufficient benefit since many modules in the stdlib predate either PEP-8 itself or the current version of PEP-8. However, enum is a new enough module that I suppose this might get accepted. In any case, thank you for wanting to contribute!

[rhettinger]

I really don't like how this patch is done or even the spirit of it. To my eyes, some of the code looks worse (especially the addition of trailing backslashes and some odd line-wraps that aren't sensitive to readability or context).

I'm going to close this. If Ethan wants to make minor tweaks to his whitespace or line-wrapping, I believe he can do a better job with his own code.

Jean-Sebastien, thank you for trying to contribute, but PEP-8ing other people's code generally isn't helpful. I recommend that you find a tracker item that needs a patch for a substantive change and work on that. I think you will find it more satisfying and will have a much greater chance of acceptance.

[realitix]

Hello Raymond Hettinger,
Thanks for your advice and your comment.

I agree with you that PEP-8 compliant isn't useful. If you look at my patch, the first change is a unused import, not just a text formatting.

Maybe this first change can be useful ? (not importing unused module)

[python-dev]

New changeset bf6987b93358 by Raymond Hettinger in branch '3.6':
Issue bpo-29103: Remove unused import. Noticed by Jean-Sebastien Bevilacqua.
https://hg.python.org/cpython/rev/bf6987b93358

[ethanfurman]

Thanks Raymond and Jean-Sebastien.