Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils: Remove unused install_misc class #73404

Closed
ericvw mannequin opened this issue Jan 9, 2017 · 5 comments
Closed

distutils: Remove unused install_misc class #73404

ericvw mannequin opened this issue Jan 9, 2017 · 5 comments
Labels
3.7 stdlib type-feature

Comments

@ericvw
Copy link
Mannequin

@ericvw ericvw mannequin commented Jan 9, 2017

BPO 29218
Nosy @merwok, @ericvw, @berkerpeksag, @dstufft
PRs
  • #552
  • Files
  • distutils-remove-install_misc-1.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-02-01.01:41:58.131>
    created_at = <Date 2017-01-09.23:01:13.503>
    labels = ['3.7', 'type-feature', 'library']
    title = 'distutils: Remove unused install_misc class'
    updated_at = <Date 2017-03-31.16:36:08.351>
    user = 'https://github.com/ericvw'

    bugs.python.org fields:

    activity = <Date 2017-03-31.16:36:08.351>
    actor = 'dstufft'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-02-01.01:41:58.131>
    closer = 'berker.peksag'
    components = ['Distutils']
    creation = <Date 2017-01-09.23:01:13.503>
    creator = 'ericvw'
    dependencies = []
    files = ['46235']
    hgrepos = []
    issue_num = 29218
    keywords = ['patch']
    message_count = 5.0
    messages = ['285080', '285281', '286578', '286579', '286580']
    nosy_count = 6.0
    nosy_names = ['gward', 'eric.araujo', 'ericvw', 'python-dev', 'berker.peksag', 'dstufft']
    pr_nums = ['552']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29218'
    versions = ['Python 3.7']

    @ericvw
    Copy link
    Mannequin Author

    @ericvw ericvw mannequin commented Jan 9, 2017

    This class hasn't been used for quite some time. Seems safe to remove.

    @ericvw ericvw mannequin added build 3.7 stdlib type-feature and removed build labels Jan 9, 2017
    @gward
    Copy link
    Mannequin

    @gward gward mannequin commented Jan 12, 2017

    LGTM, after a cursory glance at the code history. Been a loooong time since I understood this stuff deeply, though!

    @python-dev
    Copy link
    Mannequin

    @python-dev python-dev mannequin commented Feb 1, 2017

    New changeset 19c4528f53b0 by Berker Peksag in branch 'default':
    Issue bpo-29218: Remove unused install_misc command
    https://hg.python.org/cpython/rev/19c4528f53b0

    @berkerpeksag
    Copy link
    Member

    @berkerpeksag berkerpeksag commented Feb 1, 2017

    Thanks! Since Greg has given his LGTM and I couldn't find any usage of it in the wild, I've committed the patch with a NEWS entry.

    @python-dev
    Copy link
    Mannequin

    @python-dev python-dev mannequin commented Apr 9, 2022

    New changeset ef6bf4c by Berker Peksag in branch 'master':
    Issue bpo-29218: Remove unused install_misc command
    ef6bf4c

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant