Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some deprecations in the importlib #73762

Closed
Carreau mannequin opened this issue Feb 16, 2017 · 5 comments
Closed

Improve some deprecations in the importlib #73762

Carreau mannequin opened this issue Feb 16, 2017 · 5 comments
Labels
3.7 docs type-feature

Comments

@Carreau
Copy link
Mannequin

@Carreau Carreau mannequin commented Feb 16, 2017

BPO 29576
Nosy @brettcannon, @ncoghlan, @vstinner, @serhiy-storchaka, @Carreau
PRs
  • #32
  • #703
  • #552
  • #1285
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-02-16.02:00:59.787>
    created_at = <Date 2017-02-16.01:27:33.887>
    labels = ['type-feature', '3.7', 'docs']
    title = 'Improve some deprecations in the importlib'
    updated_at = <Date 2017-04-29.04:06:51.374>
    user = 'https://github.com/Carreau'

    bugs.python.org fields:

    activity = <Date 2017-04-29.04:06:51.374>
    actor = 'serhiy.storchaka'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2017-02-16.02:00:59.787>
    closer = 'brett.cannon'
    components = ['Documentation']
    creation = <Date 2017-02-16.01:27:33.887>
    creator = 'mbussonn'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 29576
    keywords = []
    message_count = 5.0
    messages = ['287908', '287909', '292277', '292286', '292561']
    nosy_count = 6.0
    nosy_names = ['brett.cannon', 'ncoghlan', 'vstinner', 'docs@python', 'serhiy.storchaka', 'mbussonn']
    pr_nums = ['32', '703', '552', '1285']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue29576'
    versions = ['Python 3.7']

    @Carreau
    Copy link
    Mannequin Author

    @Carreau Carreau mannequin commented Feb 16, 2017

    A couple of function in importlib are marked as deprecated in the documentation but do not raise deprecation warnings.

    As the same time it would be great to improve some deprecation warnings and docstring to include the version since when this is deprecated.

    This should be take care of by #32

    @Carreau Carreau mannequin added the 3.7 label Feb 16, 2017
    @Carreau Carreau mannequin assigned docspython Feb 16, 2017
    @Carreau Carreau mannequin added docs type-feature labels Feb 16, 2017
    @brettcannon
    Copy link
    Member

    @brettcannon brettcannon commented Feb 16, 2017

    New changeset 1d4601c by Brett Cannon in branch 'master':
    bpo-29576: add explicit deprecation for importlib.abc.find_loader() and find_module() (GH-32)
    1d4601c

    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Apr 25, 2017

    This change made test_importlib emitting warnings. See bpo-30158.

    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Apr 25, 2017

    This issue introduced new warnings when running test_importlib: see issue bpo-30158.

    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Apr 29, 2017

    New changeset 3cc8259 by Serhiy Storchaka in branch 'master':
    bpo-30158: Fix deprecation warnings in test_importlib introduced by bpo-29576. (bpo-1285)
    3cc8259

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 docs type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants