IDLE: Finish regrouping ConfigDialog methods

[terryjreedy]

BPO	31060
Nosy	@terryjreedy
PRs	bpo-31060: IDLE: Finish regrouping ConfigDialog methods #2908 [3.6] bpo-31060: IDLE: Finish regrouping ConfigDialog methods (GH-2908) #2925

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-07-28.00:51:27.899>
created_at = <Date 2017-07-27.18:37:03.947>
labels = ['expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: Finish regrouping ConfigDialog methods'
updated_at = <Date 2017-07-28.00:51:27.898>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2017-07-28.00:51:27.898>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-07-28.00:51:27.899>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-07-27.18:37:03.947>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 31060
keywords = []
message_count = 4.0
messages = ['299335', '299348', '299352', '299358']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = ['2908', '2925']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31060'
versions = ['Python 3.6', 'Python 3.7']

[terryjreedy]

Finish rearranging the methods of configdialog.ConfigDialog to group together methods pertaining to each tab and the button block. Doing so has and will help in writing tests. It is also preparation for splitting ConfigDialog, which currently has more than 70 methods, into multiple more maintainable classes.

bpo-30993, pr2831 moved the methods pertaining to the font tab right after create_font_tab. bpo-31003, pr2859 did the same for methods pertaining to the general tab. In both case, the generated diff had a + block at the new location and - block at the old locations.

When I did the same for the highlight tab for bpo-31001, the number of methods and lines moved was perhaps doubled, which meant that more of the other lines changed position. The result was a huge diff, by default unrendered, that deleted and inserted most of the lines in the file. Adding real edits on top of this would result in a worse huge diff.

So I decided instead to open this issue and finish method movement (for the dialog, button group, and keys group) to the extent I can now. (The order within groups may be adjusted later as tests are written and knowledge about the methods is gained.)

[terryjreedy]

After finishing the patch, I expect that the highlight and keys groups will need some changes.

[terryjreedy]

New changeset b166080 by Terry Jan Reedy in branch 'master':
bpo-31060: IDLE: Finish regrouping ConfigDialog methods (bpo-2908)
b166080

[terryjreedy]

New changeset 2cbb673 by Terry Jan Reedy in branch '3.6':
[3.6] bpo-31060: IDLE: Finish regrouping ConfigDialog methods (GH-2908) (bpo-2925)
2cbb673