-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Miscellaneous errors in asyncio speedup module #75368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Proposed patch fixes miscellaneous errors in asyncio speedup module. It is hard to enumerate they all, but they are mostly NULL dereferencing, reference leaks, and handling exceptions in corner cases. |
Adding INADA, he is a co-author/reviewer of that code. |
Huge thanks, Serhiy, btw. |
"reference leaks" oh? our Refleaks buildbots didn't catch them. Do your new tests reproduce the bugs, to make sure that we don't leak anymore? |
The test suite for Tasks and Futures is pretty extensive, but it obviously doesn't cover some obscure use cases. +1 to make sure that any refleak that was discovered should have a new regression test for it. |
They are occurred in very obscure cases like calling __init__ multiple times. The patch doesn't contain tests for them. |
FYI, there is a missing Py_DECREF from this change: https://bugs.python.org/issue40559 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: