Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 553 - built-in breakpoint() #75534

Closed
warsaw opened this issue Sep 5, 2017 · 6 comments
Closed

Implement PEP 553 - built-in breakpoint() #75534

warsaw opened this issue Sep 5, 2017 · 6 comments
Assignees
Labels
3.7 interpreter-core type-feature

Comments

@warsaw
Copy link
Member

@warsaw warsaw commented Sep 5, 2017

BPO 31353
Nosy @warsaw, @bitdancer, @serhiy-storchaka, @ethanhs, @alkuzad
PRs
  • #3355
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/warsaw'
    closed_at = <Date 2017-10-05.16:11:54.413>
    created_at = <Date 2017-09-05.20:44:20.033>
    labels = ['interpreter-core', 'type-feature', '3.7']
    title = 'Implement PEP 553 - built-in breakpoint()'
    updated_at = <Date 2018-07-09.17:47:30.913>
    user = 'https://github.com/warsaw'

    bugs.python.org fields:

    activity = <Date 2018-07-09.17:47:30.913>
    actor = 'barry'
    assignee = 'barry'
    closed = True
    closed_date = <Date 2017-10-05.16:11:54.413>
    closer = 'barry'
    components = ['Interpreter Core']
    creation = <Date 2017-09-05.20:44:20.033>
    creator = 'barry'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31353
    keywords = []
    message_count = 6.0
    messages = ['301372', '302109', '302110', '303573', '321306', '321337']
    nosy_count = 5.0
    nosy_names = ['barry', 'r.david.murray', 'serhiy.storchaka', 'ethan smith', 'alkuzad']
    pr_nums = ['3355']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31353'
    versions = ['Python 3.7']

    @warsaw
    Copy link
    Member Author

    @warsaw warsaw commented Sep 5, 2017

    Placeholder issue for discussion of the design of the implementation of PEP-553.

    @warsaw warsaw added the 3.7 label Sep 5, 2017
    @warsaw warsaw self-assigned this Sep 5, 2017
    @warsaw warsaw added the interpreter-core label Sep 5, 2017
    @alkuzad
    Copy link
    Mannequin

    @alkuzad alkuzad mannequin commented Sep 13, 2017

    Will that be backported also to Python2.7 ? I personally do not see a reason to teach old dog new tricks but it seems appropriate in such core things. New users could transition easier, otherwise this would be next py2<->py3 difference to explain every time someone uses new code.

    @bitdancer
    Copy link
    Member

    @bitdancer bitdancer commented Sep 13, 2017

    It is a new feature, so no it would not be backported.

    @bitdancer bitdancer added the type-feature label Sep 13, 2017
    @warsaw
    Copy link
    Member Author

    @warsaw warsaw commented Oct 3, 2017

    PEP is accepted. PR needs review.

    @serhiy-storchaka serhiy-storchaka changed the title Implement PEP 553 - built-in debug() Implement PEP 553 - built-in breakpoint() Oct 3, 2017
    @warsaw warsaw closed this as completed Oct 5, 2017
    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Jul 9, 2018

    Is it needed to specify the fromlist argument for PyImport_ImportModuleLevelObject()? The only effect of this is that Python will try to import the hook as a submodule if it is not an attribute of the parent module. But I think that callable modules is very uncommon case and we should not support is specially. Getting rid of the fromlist argument will simplify the code.

    @warsaw
    Copy link
    Member Author

    @warsaw warsaw commented Jul 9, 2018

    It's a convenient API. I think originally I may have just don't effectively a getattr on the imported module, but I don't remember (and don't have original implementation handy - thanks, rebase!)

    I don't have particularly strong feelings on the matter. If you want to submit a PR, I'll take a look. I suppose technically it *is* a functional change that might not be acceptable now that 3.7.0 is released though.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 interpreter-core type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants