_mboxMMDF.get_string() fails to pass param to get_bytes()

[bpoaugust]

BPO	31522
Nosy	@warsaw, @bitdancer, @iritkatriel
PRs	bpo-31522: mailbox: pass from_ parameter to get_bytes #9857

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-10-22.22:59:21.956>
created_at = <Date 2017-09-19.22:34:29.303>
labels = ['type-bug', '3.8', 'expert-email']
title = '_mboxMMDF.get_string() fails to pass param to get_bytes()'
updated_at = <Date 2020-10-22.23:01:02.267>
user = 'https://bugs.python.org/bpoaugust'

bugs.python.org fields:

activity = <Date 2020-10-22.23:01:02.267>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-22.22:59:21.956>
closer = 'barry'
components = ['email']
creation = <Date 2017-09-19.22:34:29.303>
creator = 'bpoaugust'
dependencies = []
files = []
hgrepos = []
issue_num = 31522
keywords = ['patch']
message_count = 8.0
messages = ['302564', '302569', '302571', '328013', '378757', '378758', '379378', '379379']
nosy_count = 4.0
nosy_names = ['barry', 'r.david.murray', 'bpoaugust', 'iritkatriel']
pr_nums = ['9857']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31522'
versions = ['Python 3.8']

[bpoaugust]

See:
https://github.com/python/cpython/blob/master/Lib/mailbox.py#L787

The code should be

self.get_bytes(key, from_)).as_string(unixfrom=from_)

[bpoaugust]

https://github.com/python/cpython/blob/master/Lib/mailbox.py#L778

The code here reads the first line, but fails to save it as the unixfrom line.

Alternatively perhaps it should reset the file back to the start so the message factory has sight of the envelope.

The end result is that the envelope is lost.

[bpoaugust]

Ignore msg302569 - that was supposed to be a new issue.

[bitdancer]

New changeset d16f012 by R. David Murray (Cheryl Sabella) in branch 'master':
bpo-31522: mailbox.get_string: pass from_ parameter to get_bytes (bpo-9857)
d16f012

[iritkatriel]

This seems complete, can it be closed?

[iritkatriel]

Well, the PR doesn't have a unit test so maybe not.

[warsaw]

Actually, it looks to me like the PR *does* include unittests, and I see them in the repo, so I'm closing this bug.

[iritkatriel]

Right!