Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipapp module should support compression #75819

Closed
zmwangx mannequin opened this issue Sep 29, 2017 · 3 comments
Closed

zipapp module should support compression #75819

zmwangx mannequin opened this issue Sep 29, 2017 · 3 comments
Assignees
Labels
3.7 stdlib type-feature

Comments

@zmwangx
Copy link
Mannequin

@zmwangx zmwangx mannequin commented Sep 29, 2017

BPO 31638
Nosy @pfmoore, @merwok, @zmwangx
PRs
  • #3819
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pfmoore'
    closed_at = <Date 2017-09-29.17:37:11.919>
    created_at = <Date 2017-09-29.11:12:16.606>
    labels = ['3.7', 'type-feature', 'library']
    title = 'zipapp module should support compression'
    updated_at = <Date 2017-09-29.17:37:11.919>
    user = 'https://github.com/zmwangx'

    bugs.python.org fields:

    activity = <Date 2017-09-29.17:37:11.919>
    actor = 'paul.moore'
    assignee = 'paul.moore'
    closed = True
    closed_date = <Date 2017-09-29.17:37:11.919>
    closer = 'paul.moore'
    components = ['Library (Lib)']
    creation = <Date 2017-09-29.11:12:16.606>
    creator = 'zmwangx'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31638
    keywords = ['patch', 'needs review']
    message_count = 3.0
    messages = ['303323', '303343', '303345']
    nosy_count = 3.0
    nosy_names = ['paul.moore', 'eric.araujo', 'zmwangx']
    pr_nums = ['3819']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31638'
    versions = ['Python 3.7']

    @zmwangx
    Copy link
    Mannequin Author

    @zmwangx zmwangx mannequin commented Sep 29, 2017

    Currently (up to 3.7.0a1) archives generated by the zipapp module are uncompressed, which are unnecessarily large for large projects. It's easy to add deflate compression support, and Python loads compressed archives just fine.

    I already have a patch available. I'll submit a PR soon.

    @zmwangx zmwangx mannequin added 3.8 3.7 stdlib type-feature labels Sep 29, 2017
    @merwok merwok removed the 3.8 label Sep 29, 2017
    @pfmoore
    Copy link
    Member

    @pfmoore pfmoore commented Sep 29, 2017

    Definitely. The reason it uses uncompressed files is simply an oversight on my part - I hadn't realised the default for zipfile was uncompressed.

    @pfmoore
    Copy link
    Member

    @pfmoore pfmoore commented Sep 29, 2017

    New changeset d87b105 by Paul Moore (Zhiming Wang) in branch 'master':
    bpo-31638: Add compression support to zipapp (GH-3819)
    d87b105

    @pfmoore pfmoore closed this as completed Sep 29, 2017
    @pfmoore pfmoore self-assigned this Sep 29, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants