Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sock_recv_into to AbstractEventLoop #76000

Closed
pitrou opened this issue Oct 19, 2017 · 6 comments
Closed

Add sock_recv_into to AbstractEventLoop #76000

pitrou opened this issue Oct 19, 2017 · 6 comments
Labels
3.7 expert-asyncio stdlib type-feature

Comments

@pitrou
Copy link
Member

@pitrou pitrou commented Oct 19, 2017

BPO 31819
Nosy @gvanrossum, @pitrou, @vstinner, @giampaolo, @1st1
PRs
  • #4051
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-10-19.19:47:17.426>
    created_at = <Date 2017-10-19.17:37:49.742>
    labels = ['3.7', 'type-feature', 'library', 'expert-asyncio']
    title = 'Add sock_recv_into to AbstractEventLoop'
    updated_at = <Date 2020-08-05.00:10:19.610>
    user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2020-08-05.00:10:19.610>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-10-19.19:47:17.426>
    closer = 'yselivanov'
    components = ['Library (Lib)', 'asyncio']
    creation = <Date 2017-10-19.17:37:49.742>
    creator = 'pitrou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31819
    keywords = ['patch']
    message_count = 6.0
    messages = ['304623', '304629', '304639', '304640', '304641', '374761']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'pitrou', 'vstinner', 'giampaolo.rodola', 'yselivanov']
    pr_nums = ['4051']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31819'
    versions = ['Python 3.7']

    @pitrou
    Copy link
    Member Author

    @pitrou pitrou commented Oct 19, 2017

    As sock_recv() is already exposed, it is a no-brainer to add sock_recv_into(), allowing finer buffer management when people are willing to handle a socket object.

    @pitrou pitrou added 3.7 stdlib expert-asyncio type-feature labels Oct 19, 2017
    @1st1
    Copy link
    Member

    @1st1 1st1 commented Oct 19, 2017

    I'm going to approve this unless there are any objections.

    @gvanrossum
    Copy link
    Member

    @gvanrossum gvanrossum commented Oct 19, 2017

    SGTM.

    On Oct 19, 2017 11:05 AM, "Yury Selivanov" <report@bugs.python.org> wrote:

    Yury Selivanov <yselivanov@gmail.com> added the comment:

    I'm going to approve this unless there are any objections.

    ----------
    nosy: +gvanrossum


    Python tracker <report@bugs.python.org>
    <https://bugs.python.org/issue31819\>


    @1st1
    Copy link
    Member

    @1st1 1st1 commented Oct 19, 2017

    New changeset 525f40d by Yury Selivanov (Antoine Pitrou) in branch 'master':
    bpo-31819: Add AbstractEventLoop.sock_recv_into() (bpo-4051)
    525f40d

    @1st1
    Copy link
    Member

    @1st1 1st1 commented Oct 19, 2017

    Merged. Thank you, Antoine!

    @1st1 1st1 closed this as completed Oct 19, 2017
    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Aug 3, 2020

    Follow-up issue, bpo-41467: asyncio: recv_into() must not return b'' if the socket/pipe is closed.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 expert-asyncio stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants