Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause_reading() doesn't work from connection_made() #76002

Closed
pitrou opened this issue Oct 19, 2017 · 2 comments
Closed

pause_reading() doesn't work from connection_made() #76002

pitrou opened this issue Oct 19, 2017 · 2 comments
Labels
stdlib Python modules in the Lib dir topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Oct 19, 2017

BPO 31821
Nosy @pitrou, @giampaolo, @asvetlov, @agronholm, @1st1
PRs
  • gh-76002: asyncio: allow pause_reading() from connection_made() #4053
  • gh-103607: Fixing pause_reading called in connection made is ignored #17425
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-10-19.18:49:03.117>
    labels = ['3.7', 'type-bug', 'library', 'expert-asyncio']
    title = "pause_reading() doesn't work from connection_made()"
    updated_at = <Date 2020-07-19.19:59:08.177>
    user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2020-07-19.19:59:08.177>
    actor = 'alex.gronholm'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)', 'asyncio']
    creation = <Date 2017-10-19.18:49:03.117>
    creator = 'pitrou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31821
    keywords = ['patch']
    message_count = 1.0
    messages = ['304636']
    nosy_count = 5.0
    nosy_names = ['pitrou', 'giampaolo.rodola', 'asvetlov', 'alex.gronholm', 'yselivanov']
    pr_nums = ['4053', '17425']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue31821'
    versions = ['Python 3.6', 'Python 3.7']

    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 19, 2017

    At least in SelectorEventLoop, as add_reader() is called inconditionally after connection_made() returns.

    @pitrou pitrou added 3.7 (EOL) end of life stdlib Python modules in the Lib dir topic-asyncio type-bug An unexpected behavior, bug, or error labels Oct 19, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @ezio-melotti ezio-melotti moved this to Todo in asyncio Jul 17, 2022
    @kumaraditya303 kumaraditya303 removed the 3.7 (EOL) end of life label Oct 4, 2022
    @kumaraditya303
    Copy link
    Contributor

    Duplicate of #103607

    @kumaraditya303 kumaraditya303 marked this as a duplicate of #103607 Apr 20, 2023
    @kumaraditya303 kumaraditya303 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
    @github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Apr 20, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    Status: Done
    Development

    No branches or pull requests

    2 participants