Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3.connect() should accept PathLike objects #76024

Closed
AllenLi mannequin opened this issue Oct 23, 2017 · 4 comments
Closed

sqlite3.connect() should accept PathLike objects #76024

AllenLi mannequin opened this issue Oct 23, 2017 · 4 comments
Labels
type-feature

Comments

@AllenLi
Copy link
Mannequin

@AllenLi AllenLi mannequin commented Oct 23, 2017

BPO 31843
Nosy @vstinner, @Phaqui
PRs
  • #4299
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-11-07.00:49:11.470>
    created_at = <Date 2017-10-23.00:13:44.976>
    labels = ['type-feature']
    title = 'sqlite3.connect() should accept PathLike objects'
    updated_at = <Date 2017-11-07.00:49:11.469>
    user = 'https://bugs.python.org/AllenLi'

    bugs.python.org fields:

    activity = <Date 2017-11-07.00:49:11.469>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-11-07.00:49:11.470>
    closer = 'vstinner'
    components = []
    creation = <Date 2017-10-23.00:13:44.976>
    creator = 'Allen Li'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31843
    keywords = ['patch']
    message_count = 4.0
    messages = ['304773', '305674', '305702', '305703']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'Phaqui', 'Allen Li']
    pr_nums = ['4299']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31843'
    versions = ['Python 3.6']

    @AllenLi
    Copy link
    Mannequin Author

    @AllenLi AllenLi mannequin commented Oct 23, 2017

    sqlite3.connect() should accept PathLike objects (objects that implement __fspath__)

    @AllenLi AllenLi mannequin added the type-feature label Oct 23, 2017
    @phaqui
    Copy link
    Mannequin

    @phaqui phaqui mannequin commented Nov 6, 2017

    Had my first go at a python patch. Added a test case for it, and all tests
    passing when I test with

    ./python -bb -E -Wd -m test -v test.test_sqlite -r -w -uall -R 3:2

    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Nov 7, 2017

    New changeset a22a127 by Victor Stinner (Anders Lorentsen) in branch 'master':
    bpo-31843: sqlite3.connect() now accepts PathLike objects as database name (bpo-4299)
    a22a127

    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Nov 7, 2017

    Thank you Allen Li for your feature request.

    Thank you very much Anders Lorentsen for addressing all my annoying comments on the pull request, and congratulations for your first contribution to CPython! It's a nice once ;-)

    @vstinner vstinner closed this as completed Nov 7, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant