Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean out some more AtheOS code #76047

benjaminp opened this issue Oct 25, 2017 · 4 comments

clean out some more AtheOS code #76047

benjaminp opened this issue Oct 25, 2017 · 4 comments
3.7 (EOL) end of life


Copy link

BPO 31866
Nosy @benjaminp, @serhiy-storchaka
  • fixes bpo-31866: remove code pertaining to AtheOS support #4115
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-10-26.06:55:16.238>
    created_at = <Date 2017-10-25.06:20:23.048>
    labels = ['3.7']
    title = 'clean out some more AtheOS code'
    updated_at = <Date 2017-10-26.06:55:16.237>
    user = '' fields:

    activity = <Date 2017-10-26.06:55:16.237>
    actor = 'benjamin.peterson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-10-26.06:55:16.238>
    closer = 'benjamin.peterson'
    components = []
    creation = <Date 2017-10-25.06:20:23.048>
    creator = 'benjamin.peterson'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31866
    keywords = ['patch']
    message_count = 4.0
    messages = ['304963', '304964', '305025', '305027']
    nosy_count = 2.0
    nosy_names = ['benjamin.peterson', 'serhiy.storchaka']
    pr_nums = ['4115']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = ''
    versions = ['Python 3.7']

    Copy link
    Contributor Author

    We stopped support AtheOS in 2007. But, there are still references in the code:

    $ git grep -i AtheOS
    Doc/whatsnew/2.3.rst:Other new platforms now supported by Python include AtheOS
    Doc/whatsnew/2.3.rst:(, GNU/Hurd, and OpenVMS.
    Lib/distutils/command/        # for extensions under Cygwin and AtheOS Python's library directory must be
    Lib/distutils/command/        if sys.platform[:6] == 'cygwin' or sys.platform[:6] == 'atheos':
    Lib/distutils/command/        elif sys.platform[:6] == "atheos":
    Lib/test/            # On AtheOS, glibc always returns ENOSYS
    Lib/test/            # On AtheOS, glibc always returns ENOSYS
    Misc/HISTORY:- Support for AtheOS has been completely removed from the code base. It was
    Misc/HISTORY:- Support for BeOS and AtheOS was removed (according to PEP 11).
    Misc/HISTORY:- AtheOS is now supported.
    Modules/_cryptmodule.c:    /* On some platforms (AtheOS) crypt returns NULL for an invalid
    config.guess:    i*86:atheos:*:*)
    config.guess:   echo ${UNAME_MACHINE}-unknown-atheos
    config.sub:     -atheos*)
    config.sub:             os=-atheos

    @benjaminp benjaminp added the 3.7 (EOL) end of life label Oct 25, 2017
    Copy link

    What about

    "On some platforms (AtheOS)" in the comment in Modules/_cryptmodule.c is redundant. crypt() should return NULL on error, and it often returns NULL for an invalid salt.

    Copy link
    Contributor Author

    Well, the thing is some code that fails if you're running atheos.

    Copy link
    Contributor Author

    New changeset 4eaf7f9 by Benjamin Peterson in branch 'master':
    fixes bpo-31866: remove code pertaining to AtheOS support (bpo-4115)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    3.7 (EOL) end of life
    None yet

    No branches or pull requests

    2 participants