clean out some more AtheOS code

[benjaminp]

BPO	31866
Nosy	@benjaminp, @serhiy-storchaka
PRs	fixes bpo-31866: remove code pertaining to AtheOS support #4115

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-10-26.06:55:16.238>
created_at = <Date 2017-10-25.06:20:23.048>
labels = ['3.7']
title = 'clean out some more AtheOS code'
updated_at = <Date 2017-10-26.06:55:16.237>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2017-10-26.06:55:16.237>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2017-10-26.06:55:16.238>
closer = 'benjamin.peterson'
components = []
creation = <Date 2017-10-25.06:20:23.048>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 31866
keywords = ['patch']
message_count = 4.0
messages = ['304963', '304964', '305025', '305027']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'serhiy.storchaka']
pr_nums = ['4115']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue31866'
versions = ['Python 3.7']

[benjaminp]

We stopped support AtheOS in 2007. But, there are still references in the code:

$ git grep -i AtheOS
Doc/whatsnew/2.3.rst:Other new platforms now supported by Python include AtheOS
Doc/whatsnew/2.3.rst:(http://atheos.cx/), GNU/Hurd, and OpenVMS.
Lib/distutils/command/build_ext.py:        # for extensions under Cygwin and AtheOS Python's library directory must be
Lib/distutils/command/build_ext.py:        if sys.platform[:6] == 'cygwin' or sys.platform[:6] == 'atheos':
Lib/distutils/command/build_ext.py:        elif sys.platform[:6] == "atheos":
Lib/test/test_os.py:            # On AtheOS, glibc always returns ENOSYS
Lib/test/test_os.py:            # On AtheOS, glibc always returns ENOSYS
Misc/HISTORY:- Support for AtheOS has been completely removed from the code base. It was
Misc/HISTORY:- Support for BeOS and AtheOS was removed (according to PEP 11).
Misc/HISTORY:- AtheOS is now supported.
Modules/_cryptmodule.c:    /* On some platforms (AtheOS) crypt returns NULL for an invalid
config.guess:    i*86:atheos:*:*)
config.guess:   echo ${UNAME_MACHINE}-unknown-atheos
config.sub:     -atheos*)
config.sub:             os=-atheos
configure:atheos*|Linux*/1*)
configure.ac:atheos*|Linux*/1*)

[serhiy-storchaka]

What about configure.ac?

"On some platforms (AtheOS)" in the comment in Modules/_cryptmodule.c is redundant. crypt() should return NULL on error, and it often returns NULL for an invalid salt.

[benjaminp]

Well, the configure.ac thing is some code that fails if you're running atheos.

[benjaminp]

New changeset 4eaf7f9 by Benjamin Peterson in branch 'master':
fixes bpo-31866: remove code pertaining to AtheOS support (bpo-4115)
4eaf7f9