Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate openfp() in aifc, sunau and wave #76166

Closed
briancurtin opened this issue Nov 8, 2017 · 8 comments
Closed

Deprecate openfp() in aifc, sunau and wave #76166

briancurtin opened this issue Nov 8, 2017 · 8 comments
Assignees
Labels
3.7 stdlib type-feature

Comments

@briancurtin
Copy link
Member

@briancurtin briancurtin commented Nov 8, 2017

BPO 31985
Nosy @vstinner, @briancurtin, @serhiy-storchaka
PRs
  • #4344
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/briancurtin'
    closed_at = <Date 2019-06-17.20:12:59.749>
    created_at = <Date 2017-11-08.21:56:36.323>
    labels = ['3.7', 'type-feature', 'library']
    title = 'Deprecate openfp() in aifc, sunau and wave'
    updated_at = <Date 2019-06-17.20:12:59.747>
    user = 'https://github.com/briancurtin'

    bugs.python.org fields:

    activity = <Date 2019-06-17.20:12:59.747>
    actor = 'vstinner'
    assignee = 'brian.curtin'
    closed = True
    closed_date = <Date 2019-06-17.20:12:59.749>
    closer = 'vstinner'
    components = ['Library (Lib)']
    creation = <Date 2017-11-08.21:56:36.323>
    creator = 'brian.curtin'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 31985
    keywords = ['patch']
    message_count = 8.0
    messages = ['305912', '305917', '305924', '305989', '305995', '305999', '306038', '345896']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'brian.curtin', 'serhiy.storchaka']
    pr_nums = ['4344']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue31985'
    versions = ['Python 3.7']

    @briancurtin
    Copy link
    Member Author

    @briancurtin briancurtin commented Nov 8, 2017

    Since 1993, aifc.openfp has simply pointed to aifc.open as a matter of backwards compatibility. See 7bc817d for the exact change.

    aifc.openfp is both undocumented and untested, and in looking at doc coverage I decided it's better to deprecate it since it's silently been there for 25 years.

    @briancurtin briancurtin added the 3.7 label Nov 8, 2017
    @briancurtin briancurtin self-assigned this Nov 8, 2017
    @briancurtin briancurtin added stdlib type-feature labels Nov 8, 2017
    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Nov 8, 2017

    Don't forget about wave and sunau.

    You can use a common test for all three modules.

    @briancurtin
    Copy link
    Member Author

    @briancurtin briancurtin commented Nov 9, 2017

    i was going to do them as separate bugs and PRs per module, but if one is fine then i can do that.

    Updating the title as well since nothing is beings removed (was originally going to suggest skipping to removal but won’t do that).

    @briancurtin briancurtin changed the title Deprecate/remove aifc.openfp Deprecate aifc.openfp Nov 9, 2017
    @serhiy-storchaka serhiy-storchaka changed the title Deprecate aifc.openfp Deprecate openfp() in aifc, sunau and wave Nov 9, 2017
    @briancurtin
    Copy link
    Member Author

    @briancurtin briancurtin commented Nov 9, 2017

    Serhiy, where should a common test that covers all three of these go? I'm not seeing an obvious place for it.

    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Nov 9, 2017

    audiotests.py. Create class AudioMiscTests and inherit classes AifcMiscTest, SunauMiscTest, WaveMiscTest from it instead of AudioTests. There is more work because there was no base for misc tests, but this will make adding other common misc test easier.

    @briancurtin
    Copy link
    Member Author

    @briancurtin briancurtin commented Nov 9, 2017

    I think #4344 covers what you're looking for.

    @briancurtin
    Copy link
    Member Author

    @briancurtin briancurtin commented Nov 10, 2017

    New changeset 9f914a0 by Brian Curtin in branch 'master':
    bpo-31985: Deprecate openfp in aifc, sunau, and wave (bpo-4344)
    9f914a0

    @vstinner
    Copy link
    Member

    @vstinner vstinner commented Jun 17, 2019

    I created bpo-37320: "aifc, sunau, wave: remove deprecated openfp() function".

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants