-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
asyncio: Don't export selectors and _overlapped in asyncio namespace #76335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For backward compatibility with Python 3.3, Lib/asyncio/init.py exports asyncio.selectors and asyncio._overlapped symbols. Python 3.3 reached it's end of line last september, it's time to move on: This change is backward incompatible. Attached PR removes asyncio.selectors and asyncio._overlapped symbols, and use directly modules from the standard library. It documents the change in the "Porting to Python 3.7" section of the "What's New in Python 3.7" document. |
I also proposed the PR 4609 to remove the old asyncio.windows_utils.socketpair alias. |
Is this function publicly documented? If this is true, it should first be deprecated. It is left in the __all__ list. |
Serhiy Storchaka: "Is this function publicly documented? If this is true, it should first be deprecated." It's not documented, but I found a reference in the documentation: This code continues to work on Python 3.5 and newer, the "except" block will just never be taken.
Oops, fixed in my PR. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: