linecache.py add lazycache to __all__ and use dict.clear to clear the cache

[ganziqim]

BPO	32173
Nosy	@akuchling, @rhettinger, @serhiy-storchaka, @lisroach, @ganziqim
PRs	bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #4603 bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache #4641 bpo-32173: linecache.py add lazycache to __all__ and use dict.clear to clear the cache  #10130

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/lisroach'
closed_at = <Date 2020-03-21.00:28:33.453>
created_at = <Date 2017-11-30.02:57:02.561>
labels = ['type-bug', 'library']
title = 'linecache.py add lazycache to __all__ and use dict.clear to clear the cache'
updated_at = <Date 2020-03-21.00:28:33.449>
user = 'https://github.com/GanZiQim'

bugs.python.org fields:

activity = <Date 2020-03-21.00:28:33.449>
actor = 'akuchling'
assignee = 'lisroach'
closed = True
closed_date = <Date 2020-03-21.00:28:33.453>
closer = 'akuchling'
components = ['Library (Lib)']
creation = <Date 2017-11-30.02:57:02.561>
creator = 'ganziqim'
dependencies = []
files = []
hgrepos = []
issue_num = 32173
keywords = ['patch']
message_count = 5.0
messages = ['307406', '307409', '307419', '328571', '364724']
nosy_count = 5.0
nosy_names = ['akuchling', 'rhettinger', 'serhiy.storchaka', 'lisroach', 'ganziqim']
pr_nums = ['4603', '4641', '10130']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32173'
versions = ['Python 3.6']

[rhettinger]

These seems to be reasonable suggestions.

Lisa, would you care to review the patch?

[serhiy-storchaka]

Could you please explain your suggestion ganziqim?

The patch looks like a collection of unrelated changes mostly changing the formatting of the code. Usually we don't do such changes. If there is a semantical change, it is hidden in a source churn.

[lisroach]

I think these changes look good, ganziqim has real code improvements (in the form of adding lazycache to __all__ and using clear() in clearchache), as well as improving the code formatting for readability.

[serhiy-storchaka]

Since all proposed PRs just change formatting, I suggest to close this issue.

[akuchling]

Patch has been applied.