Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert asyncio to async/await #76374

Closed
asvetlov opened this issue Dec 1, 2017 · 6 comments
Closed

Convert asyncio to async/await #76374

asvetlov opened this issue Dec 1, 2017 · 6 comments
Assignees
Labels
3.7 expert-asyncio stdlib type-feature

Comments

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Dec 1, 2017

BPO 32193
Nosy @gvanrossum, @terryjreedy, @asvetlov, @1st1
PRs
  • #4753
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/asvetlov'
    closed_at = <Date 2017-12-08.22:25:13.912>
    created_at = <Date 2017-12-01.09:44:32.672>
    labels = ['3.7', 'type-feature', 'library', 'expert-asyncio']
    title = 'Convert asyncio to async/await'
    updated_at = <Date 2017-12-08.22:25:13.911>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2017-12-08.22:25:13.911>
    actor = 'asvetlov'
    assignee = 'asvetlov'
    closed = True
    closed_date = <Date 2017-12-08.22:25:13.912>
    closer = 'asvetlov'
    components = ['Library (Lib)', 'asyncio']
    creation = <Date 2017-12-01.09:44:32.672>
    creator = 'asvetlov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32193
    keywords = ['patch']
    message_count = 6.0
    messages = ['307375', '307392', '307393', '307394', '307403', '307872']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'terry.reedy', 'asvetlov', 'yselivanov']
    pr_nums = ['4753']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32193'
    versions = ['Python 3.7']

    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 1, 2017

    As discussed several times before we need to convert @coroutine / yield from to async/await.

    All existing functionality should keep working (like yielding from new style coroutine and with (yield from lock).

    We could deprecate the later though.

    The change should be huge but there is no alternative, keeping yield from in stdlib looks uglier and uglier every year.

    Unittests should be changed as well (keeping several yield from for checking backward compatibility is Ok).

    Opinions?

    @asvetlov asvetlov added the 3.7 label Dec 1, 2017
    @asvetlov asvetlov self-assigned this Dec 1, 2017
    @asvetlov asvetlov added stdlib expert-asyncio type-feature labels Dec 1, 2017
    @gvanrossum
    Copy link
    Member

    @gvanrossum gvanrossum commented Dec 1, 2017

    Yeah, I am in favor of this. How will we guarantee that clients using the old @coroutine/yield from idiom still work? We need to have separate tests for that.

    @1st1
    Copy link
    Member

    @1st1 1st1 commented Dec 1, 2017

    How will we guarantee that clients using the old @coroutine/yield from idiom still work?

    They are fully supported now, but we can add a few tests to ensure we won't break it.

    @1st1
    Copy link
    Member

    @1st1 1st1 commented Dec 1, 2017

    Andrew, would it be OK if I make a PR?

    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 1, 2017

    Yuri please do

    @asvetlov
    Copy link
    Contributor Author

    @asvetlov asvetlov commented Dec 8, 2017

    New changeset 5f841b5 by Andrew Svetlov in branch 'master':
    bpo-32193: Convert asyncio to async/await usage (bpo-4753)
    5f841b5

    @asvetlov asvetlov closed this as completed Dec 8, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 expert-asyncio stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants