-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
When using a Windows XP compatible toolset, socketmodule.c
fails to build
#76463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If Python is built using the Windows XP "variant" of the toolset (e.g. We'll be contributing our patch to this issue here. |
|
If you can't compile, security fixes aren't worth anything. And while we don't support XP, the v140_xp toolset is in more of a grey area. There are real ways you could be forced into using it besides targeting XP. Max - I'd rather just remove the ifdef checks completely. Fairly sure I added them in the migration from VC10, but they are simply incorrect (the header is from the WinSDK which is not the same as _MSC_VER) and will always be there for the versions of the SDK we allow, even back to 3.5. |
Works for me. We no longer rely on the |
It looks like we need to backport this manually for 3.5 (if Larry approves) |
I'm going to just close this without fixing 3.5. If there's demand, we can consider it, but at this stage it's so easy for people to migrate to 3.6 or later that I'm sure that's already been done. |
VersionHelpers.h
insocketmodule.c
on Windows #4805VersionHelpers.h
insocketmodule.c
on Windows #5120Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: