unittest.mock.patch.dict.__enter__ should return the dict

[AllenLi]

BPO	32299
Nosy	@rbtcollins, @voidspace, @csabella, @tirkarthi
PRs	bpo-32299: unittest.mock.patch.dict now returns patched dict when used as context manager #4834 bpo-32299: Return patched dict when using patch.dict as a context manager #11062

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-05-28.12:59:19.049>
created_at = <Date 2017-12-13.07:08:20.287>
labels = ['3.8', 'type-feature', 'library']
title = 'unittest.mock.patch.dict.__enter__ should return the dict'
updated_at = <Date 2019-05-28.12:59:19.048>
user = 'https://bugs.python.org/AllenLi'

bugs.python.org fields:

activity = <Date 2019-05-28.12:59:19.048>
actor = 'cheryl.sabella'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-28.12:59:19.049>
closer = 'cheryl.sabella'
components = ['Library (Lib)']
creation = <Date 2017-12-13.07:08:20.287>
creator = 'Allen Li'
dependencies = []
files = []
hgrepos = []
issue_num = 32299
keywords = ['patch']
message_count = 4.0
messages = ['308188', '310489', '343772', '343775']
nosy_count = 5.0
nosy_names = ['rbcollins', 'michael.foord', 'cheryl.sabella', 'Allen Li', 'xtreak']
pr_nums = ['4834', '11062']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32299'
versions = ['Python 3.8']

[AllenLi]

mock.patch.dict.__enter__ should return the patched dict/mapping object.

Currently it returns nothing (None).

This would make setting up fixtures more convenient:

 with mock.patch.dict(some.thing):
   some.thing['foo'] = 'bar'

 with mock.patch.dict(some.thing) as x:
   x['foo'] = 'bar'

[voidspace]

This seems like a reasonable feature request.

[csabella]

New changeset 0453081 by Cheryl Sabella (Mario Corchero) in branch 'master':
bpo-32299: Return patched dict when using patch.dict as a context manager (GH-11062)
0453081

[csabella]

@allen Li, thank you for the report. And thank you, @vadim Tsander for the original pull request and @mariocj89 for reviving this. Also, thank you @eric.araujo for the review and approval. This has been merged!